Review TYPO3_8-7 Merged

54427[BUGFIX] Localization State does not properly sanitize and enrich

Christian Kuhn CR +2 V +2 Normal +212 −4 updated 10/17/17, 23:14

Commit message

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
* localization state could contain fields that were not defined in TCA
  having support for the `allowLanguageSynchronization` setting
* state values different than `custom`, `source` or `parent` have not
  been overridden by the default `parent` value

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 10/17/17, 22:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/17/17, 23:01 Completed build in 13m 37s on Wed, 18 Oct, 01:01 AM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1081

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 10/17/17, 23:14

  4. Gerrit merged patch set 1 10/17/17, 23:14