Review main Merged

54433[BUGFIX] Delete unavailable "recently switched to" users from UC

Andreas Kienast CR +2 V +2 Easy +32 −8 updated 10/19/17, 19:11

Commit message

If a user who appears in the "Recently switched to" list became
unavailable for some reason, only the placeholder avatar was rendered,
giving a slight hint of life in the past.

Such users are now deleted from UC and do not appear in the list anymore.
Furthermore, the section label was slightly modified to be more
understandable.

For performance reasons, only one query is triggered now and sorting is
done based on the array of UIDs stored in UC.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 2127

Show 12 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/18/17, 06:57

  2. TYPO3com voted on patch set 1 V +1 10/18/17, 07:07 Completed build in 09m 54s on Wed, 18 Oct, 09:07 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15755

  1. Wouter Wolters voted on patch set 1 CR +1 10/18/17, 07:11

  2. Andreas Kienast commented on patch set 1 CR -1 10/18/17, 07:25

    Found another bug in here
  3. Andreas Kienast uploaded patch set 2 10/18/17, 07:29

  4. TYPO3com voted on patch set 2 V +1 10/18/17, 07:38 Completed build in 09m 19s on Wed, 18 Oct, 09:38 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15757

  5. Andreas Kienast uploaded patch set 3 10/18/17, 07:59

  6. TYPO3com voted on patch set 3 V +1 10/18/17, 08:09 Completed build in 09m 42s on Wed, 18 Oct, 10:09 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15759

  7. Jörg Bösche commented on patch set 3 CR +1 V +1 10/18/17, 08:26

    Reproduce the behaviour (before the patch): 1. Switch user to another user (SU) 2. Leave su mode 3. Click on the user profile toolbar 4. "Recently switched to user" shows an "deleted user".
  8. Wouter Wolters commented on patch set 3 10/18/17, 09:26

    UserToolbarItem.php:77

    this will execute a query for each user, can't we fetch all in once?
  9. Andreas Kienast commented on patch set 3 10/18/17, 09:33

    UserToolbarItem.php:77 Reply

    No, as I want to preserve the order as defined in UC and there is afaik currently no possibility to pass this to Doctrine. In plain MySQL, I'd use something like `ORDER BY FIELD(uid, $recentSwitchedToUsers)`
  10. Wouter Wolters voted on patch set 3 CR +1 10/18/17, 09:46

  11. Andreas Kienast updated the commit message in patch set 4 10/18/17, 11:41

  12. TYPO3com voted on patch set 4 V +1 10/18/17, 11:51 Completed build in 09m 34s on Wed, 18 Oct, 01:51 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15762

  13. Jörg Bösche voted on patch set 4 CR +1 V +1 10/18/17, 13:01

  14. Wouter Wolters voted on patch set 4 CR +1 10/18/17, 13:30

  15. Mathias Schreiber commented on patch set 4 CR -1 V +1 10/18/17, 20:08

    UserToolbarItem.php:76

    do we need a loop here? I wonder if we can't just select be_users.uid IN (implode(uidListArray)) and then loop over the resultset.
  16. Andreas Kienast commented on patch set 4 CR -1 10/18/17, 20:13

    The amount of queries is too damn high!
  17. Mathias Schreiber voted on patch set 4 CR 0 10/18/17, 20:14

  18. Andreas Kienast uploaded patch set 5 10/18/17, 20:35

  19. TYPO3com voted on patch set 5 V -1 10/18/17, 20:35 Completed build in 09s on Wed, 18 Oct, 10:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15781

  20. Andreas Kienast uploaded patch set 6 10/18/17, 20:36

  21. Mathias Schreiber voted on patch set 6 CR +1 V +1 10/18/17, 20:39

  22. TYPO3com voted on patch set 6 V +1 10/18/17, 20:45 Completed build in 08m 25s on Wed, 18 Oct, 10:45 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15782

  23. Jörg Bösche commented on patch set 6 CR +1 V +1 10/19/17, 06:28

    Good job!
  24. Christian Kuhn voted on patch set 6 CR +2 V +2 10/19/17, 19:11

  25. Gerrit merged patch set 6 10/19/17, 19:11