Review main Merged

54435[BUGFIX] EXT:form - really disable records overview in redirect finisher

Mathias Brodala CR +2 V +2 Easy +4 −4 updated 08/20/18, 20:10

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Ioulia Kondratovitch +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Ioulia Kondratovitch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1113

  1. Mathias Brodala uploaded patch set 1 10/18/17, 07:39

  2. TYPO3com voted on patch set 1 V -1 10/18/17, 07:48 Completed build in 08m 27s on Wed, 18 Oct, 09:48 AM Test Summary: 1 of 57115 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15758

  3. TYPO3com voted on patch set 1 V +1 10/18/17, 07:52 Completed build in 21m 22s on Wed, 18 Oct, 09:52 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15758

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/18/17, 09:45

  5. Stefan Neufeind voted on patch set 1 CR +1 V +1 10/25/17, 21:48

  6. Stefan Neufeind commented on patch set 1 10/25/17, 21:49

    just fyi: also affects EXT:styleguide, pull-request created now at https://github.com/TYPO3/styleguide/pull/104
  7. Wouter Wolters voted on patch set 1 CR +2 V +2 10/30/17, 20:25

  8. Gerrit merged patch set 1 10/30/17, 20:25

  9. Wouter Wolters commented on patch set 2 10/30/17, 20:31

  10. Wolfgang Klinger commented on patch set 2 04/25/18, 09:17

    The backport to 8.7 is needed imho, the bug is the same there (the missing 's').
  11. Ioulia Kondratovitch commented on patch set 2 V +1 CR +1 08/04/18, 10:30

    The backport to 8.7 is still needed
  12. Wouter Wolters commented on patch set 2 08/05/18, 12:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0f733ac3b9eab191f014c152eaa90aa4a04c4bd3
  13. Oliver Hader commented on patch set 2 08/20/18, 20:10

    Looks good, however adding one more sentence to the commit message, e.g. that this was just a typing error would have been good. Thx ;-)