54435[BUGFIX] EXT:form - really disable records overview in redirect finisher
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Ioulia Kondratovitch +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Ioulia Kondratovitch +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1113
-
Mathias Brodala uploaded patch set 1 10/18/17, 07:39
-
TYPO3com voted on patch set 1 V -1 10/18/17, 07:48 Completed build in 08m 27s on Wed, 18 Oct, 09:48 AM Test Summary: 1 of 57115 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15758
-
TYPO3com voted on patch set 1 V +1 10/18/17, 07:52 Completed build in 21m 22s on Wed, 18 Oct, 09:52 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15758
-
Wouter Wolters voted on patch set 1 CR +1 V +1 10/18/17, 09:45
-
Stefan Neufeind voted on patch set 1 CR +1 V +1 10/25/17, 21:48
-
Stefan Neufeind commented on patch set 1 10/25/17, 21:49
just fyi: also affects EXT:styleguide, pull-request created now at https://github.com/TYPO3/styleguide/pull/104 -
Wouter Wolters voted on patch set 1 CR +2 V +2 10/30/17, 20:25
-
Gerrit merged patch set 1 10/30/17, 20:25
-
Wouter Wolters commented on patch set 2 10/30/17, 20:31
No backport to 8.7 needed. All is correct there. Wrongly commit was https://github.com/TYPO3/TYPO3.CMS/commit/84be5e616b5373ac7ba57edf2d3cd61251dc6f97#diff-0e18d8480b13f2c85c499b9dfaf5a8e6 -
Wolfgang Klinger commented on patch set 2 04/25/18, 09:17
The backport to 8.7 is needed imho, the bug is the same there (the missing 's'). -
Ioulia Kondratovitch commented on patch set 2 V +1 CR +1 08/04/18, 10:30
The backport to 8.7 is still needed -
Wouter Wolters commented on patch set 2 08/05/18, 12:12
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0f733ac3b9eab191f014c152eaa90aa4a04c4bd3 -
Oliver Hader commented on patch set 2 08/20/18, 20:10
Looks good, however adding one more sentence to the commit message, e.g. that this was just a typing error would have been good. Thx ;-)