54437[TASK] Show allowed media sources in "Add media by URL" modal
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Sascha Rademacher +1
- Henning Liebe +1
- Jörg Bösche +1
-
Verified V +2
- Jigal van Hemert +2
- Henning Liebe +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Resources/Public/Sass/component/_modal.scss1+4 −0
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+2 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js+5 −1
- typo3/sysext/lang/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 2534
Show 59 earlier messages
-
Gianluigi Martino uploaded patch set 1 10/18/17, 15:26
-
Gianluigi Martino commented on patch set 2 10/18/17, 15:29
Published edit on patch set 1. -
Gianluigi Martino commented on patch set 3 10/18/17, 15:30
Published edit on patch set 2. -
TYPO3com voted on patch set 1 V -1 10/18/17, 15:36 Completed build in 09m 45s on Wed, 18 Oct, 05:36 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15768
-
TYPO3com voted on patch set 2 V -1 10/18/17, 15:40 Completed build in 10m 56s on Wed, 18 Oct, 05:40 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15769
-
TYPO3com voted on patch set 3 V -1 10/18/17, 15:40 Completed build in 10m 30s on Wed, 18 Oct, 05:40 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15770
-
Gianluigi Martino uploaded patch set 4 10/18/17, 15:45
-
TYPO3com voted on patch set 4 V -1 10/18/17, 15:54 Completed build in 08m 57s on Wed, 18 Oct, 05:54 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15771
-
Andreas Kienast commented on patch set 4 CR -1 10/18/17, 18:00
_modal.scss:64Please remove "px" here
-
Andreas Kienast uploaded patch set 5 10/18/17, 19:09
-
TYPO3com voted on patch set 5 V +1 10/18/17, 19:19 Completed build in 09m 39s on Wed, 18 Oct, 09:19 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15775
-
Gianluigi Martino voted on patch set 5 V +1 10/20/17, 07:42
-
Gianluigi Martino rebased onto patch set 6 10/20/17, 10:35
-
Gianluigi Martino commented on patch set 6 CR +1 V +1 10/20/17, 10:44
Rebasing was a mistake, sorry -
TYPO3com voted on patch set 6 V +1 10/20/17, 10:47 Completed build in 11m 40s on Fri, 20 Oct, 12:47 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15813
-
Riccardo De Contardi commented on patch set 6 V +1 10/21/17, 15:10
Suggestion: change the label from "Allowed file extensions:" to "Allow to embed from sources:" or something like that -
Jörg Bösche commented on patch set 7 10/23/17, 07:39
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V +1 10/23/17, 07:53 Completed build in 13m 33s on Mon, 23 Oct, 09:53 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15843
-
Henning Liebe voted on patch set 7 CR +1 V +1 10/23/17, 08:26
-
Henning Liebe commented on patch set 7 V -1 10/23/17, 08:33
I'm on it. Wrong translation used -
Henning Liebe uploaded patch set 8 10/23/17, 08:38
-
Jan Stockfisch voted on patch set 8 CR +1 V +1 10/23/17, 08:47
-
TYPO3com voted on patch set 8 V +1 10/23/17, 08:49 Completed build in 10m 44s on Mon, 23 Oct, 10:49 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15848
-
Jörg Bösche voted on patch set 8 CR +1 V +1 10/23/17, 08:50
-
Riccardo De Contardi voted on patch set 8 V +1 10/23/17, 19:07
-
Rémy DANIEL voted on patch set 8 CR +1 10/24/17, 12:15
-
Gianluigi Martino voted on patch set 8 CR +1 V +1 10/24/17, 14:09
-
Jigal van Hemert commented on patch set 9 11/01/17, 12:34
Published edit on patch set 8. -
Jigal van Hemert commented on patch set 9 CR +2 V +2 11/01/17, 12:36
Just corrected the commit message and changed the label text. -
Sascha Rademacher voted on patch set 9 CR +1 11/01/17, 12:40
-
TYPO3com voted on patch set 9 V +1 11/01/17, 12:44 Completed build in 09m 53s on Wed, 1 Nov, 01:44 PM Test Summary: 56936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15962
-
Jörg Bösche voted on patch set 9 CR +1 V +1 11/01/17, 12:45
-
Henning Liebe voted on patch set 9 CR +1 V +1 11/01/17, 12:46
-
Gerrit merged patch set 9 11/01/17, 14:39