Review main Merged

54437[TASK] Show allowed media sources in "Add media by URL" modal

Gianluigi Martino CR +2 V +2 Easy +15 −2 updated 11/01/17, 14:39

Commit message

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Sascha Rademacher +1
    • Henning Liebe +1
    • Jörg Bösche +1
  • Verified V +2
    • Jigal van Hemert +2
    • Henning Liebe +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2534

Show 59 earlier messages
  1. Gianluigi Martino uploaded patch set 1 10/18/17, 15:26

  2. Gianluigi Martino commented on patch set 2 10/18/17, 15:29

    Published edit on patch set 1.
  3. Gianluigi Martino commented on patch set 3 10/18/17, 15:30

    Published edit on patch set 2.
  4. TYPO3com voted on patch set 1 V -1 10/18/17, 15:36 Completed build in 09m 45s on Wed, 18 Oct, 05:36 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15768

  5. TYPO3com voted on patch set 2 V -1 10/18/17, 15:40 Completed build in 10m 56s on Wed, 18 Oct, 05:40 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15769

  6. TYPO3com voted on patch set 3 V -1 10/18/17, 15:40 Completed build in 10m 30s on Wed, 18 Oct, 05:40 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15770

  7. Gianluigi Martino uploaded patch set 4 10/18/17, 15:45

  8. TYPO3com voted on patch set 4 V -1 10/18/17, 15:54 Completed build in 08m 57s on Wed, 18 Oct, 05:54 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15771

  9. Andreas Kienast commented on patch set 4 CR -1 10/18/17, 18:00

    _modal.scss:64

    Please remove "px" here
  1. Andreas Kienast uploaded patch set 5 10/18/17, 19:09

  2. TYPO3com voted on patch set 5 V +1 10/18/17, 19:19 Completed build in 09m 39s on Wed, 18 Oct, 09:19 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15775

  3. Gianluigi Martino voted on patch set 5 V +1 10/20/17, 07:42

  4. Gianluigi Martino rebased onto patch set 6 10/20/17, 10:35

  5. Gianluigi Martino commented on patch set 6 CR +1 V +1 10/20/17, 10:44

    Rebasing was a mistake, sorry
  6. TYPO3com voted on patch set 6 V +1 10/20/17, 10:47 Completed build in 11m 40s on Fri, 20 Oct, 12:47 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15813

  7. Riccardo De Contardi commented on patch set 6 V +1 10/21/17, 15:10

    Suggestion: change the label from "Allowed file extensions:" to "Allow to embed from sources:" or something like that
  8. Jörg Bösche commented on patch set 7 10/23/17, 07:39

    Published edit on patch set 6.
  9. TYPO3com voted on patch set 7 V +1 10/23/17, 07:53 Completed build in 13m 33s on Mon, 23 Oct, 09:53 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15843

  10. Henning Liebe voted on patch set 7 CR +1 V +1 10/23/17, 08:26

  11. Henning Liebe commented on patch set 7 V -1 10/23/17, 08:33

    I'm on it. Wrong translation used
  12. Henning Liebe uploaded patch set 8 10/23/17, 08:38

  13. Jan Stockfisch voted on patch set 8 CR +1 V +1 10/23/17, 08:47

  14. TYPO3com voted on patch set 8 V +1 10/23/17, 08:49 Completed build in 10m 44s on Mon, 23 Oct, 10:49 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15848

  15. Jörg Bösche voted on patch set 8 CR +1 V +1 10/23/17, 08:50

  16. Riccardo De Contardi voted on patch set 8 V +1 10/23/17, 19:07

  17. Rémy DANIEL voted on patch set 8 CR +1 10/24/17, 12:15

  18. Gianluigi Martino voted on patch set 8 CR +1 V +1 10/24/17, 14:09

  19. Jigal van Hemert commented on patch set 9 11/01/17, 12:34

    Published edit on patch set 8.
  20. Jigal van Hemert commented on patch set 9 CR +2 V +2 11/01/17, 12:36

    Just corrected the commit message and changed the label text.
  21. Sascha Rademacher voted on patch set 9 CR +1 11/01/17, 12:40

  22. TYPO3com voted on patch set 9 V +1 11/01/17, 12:44 Completed build in 09m 53s on Wed, 1 Nov, 01:44 PM Test Summary: 56936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15962

  23. Jörg Bösche voted on patch set 9 CR +1 V +1 11/01/17, 12:45

  24. Henning Liebe voted on patch set 9 CR +1 V +1 11/01/17, 12:46

  25. Gerrit merged patch set 9 11/01/17, 14:39