Review main Merged Breaking

54438[!!!][TASK] Remove "content_doktypes"

Benni Mack CR +2 V +2 Normal +38 −15 updated 10/19/17, 08:13

Commit message

The global option "content_doktypes" is
1. outdated (still contains doktypes 2 which was removed in 4.x)
2. only in use for Workspace Preview Links and Frontend Editing to query page trees

However, the idea was to disallow content editing (QuickEdit) and skip
search of other doktypes for simple DB search (removed in TYPO3 v7)

This is not the case anymore and nowadays a hidden feature which is only
10% implemented, and just another tedious option bloating the system.

The option has been removed and also cleaned via SilentConfigurationUpgradeService.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Mathias Schreiber +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 912

  1. Benni Mack uploaded patch set 1 10/18/17, 18:41

  2. TYPO3com voted on patch set 1 V +1 10/18/17, 18:50 Completed build in 08m 48s on Wed, 18 Oct, 08:50 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15773

  3. Christian Kuhn commented on patch set 1 10/18/17, 18:51

    SilentConfigurationUpgradeService.php:122

    FR/ vs. FE/
  4. Benni Mack commented on patch set 2 10/18/17, 19:01

    Published edit on patch set 1.
  5. Andreas Kienast voted on patch set 2 CR +1 10/18/17, 19:07

  6. TYPO3com voted on patch set 2 V +1 10/18/17, 19:11 Completed build in 09m 37s on Wed, 18 Oct, 09:11 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15774

  7. Mathias Schreiber updated the commit message in patch set 3 10/18/17, 19:56

  8. Mathias Schreiber voted on patch set 3 CR +1 V +1 10/18/17, 19:58

  9. Andreas Kienast voted on patch set 3 CR +1 10/18/17, 20:02

  10. TYPO3com voted on patch set 3 V +1 10/18/17, 20:06 Completed build in 09m 06s on Wed, 18 Oct, 10:06 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15778

  11. Georg Ringer voted on patch set 3 CR +2 V +2 10/19/17, 08:12

  12. Gerrit merged patch set 3 10/19/17, 08:13