Review main Merged

54443[BUGFIX] Allow longer file-endings in typoscript directory includes

Mathias Schreiber CR +2 V +2 Easy +12 −9 updated 10/20/17, 12:44

Commit message

Directory includes now allow more liberal substrings to include files
not only based on their extension (*.typoscript) but based on the last
part of their filename (*.setup.typoscript).

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2
    • Benjamin Kott +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Mathias Schreiber uploaded patch set 1 10/18/17, 23:14

  2. TYPO3com voted on patch set 1 V +1 10/18/17, 23:24 Completed build in 09m 49s on Thu, 19 Oct, 01:24 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15785

  3. Andreas Kienast commented on patch set 1 10/19/17, 06:08

    GeneralUtility.php:2242

    No Foo fighters here, sorry.
  4. Andreas Kienast commented on patch set 2 10/19/17, 06:08

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V -1 10/19/17, 06:18 Completed build in 09m 10s on Thu, 19 Oct, 08:18 AM Test Summary: 1 of 57115 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15786

  6. TYPO3com voted on patch set 2 V +1 10/19/17, 06:25 Completed build in 25m 26s on Thu, 19 Oct, 08:25 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15786

  7. Benni Mack voted on patch set 2 CR +1 V +1 10/20/17, 12:21

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 10/20/17, 12:44

  9. Gerrit merged patch set 2 10/20/17, 12:44

  10. Benjamin Kott commented on patch set 3 10/20/17, 12:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 231602cfc960c4f2ea81013356de52e00223189e