Review main Merged

54444[BUGFIX] MenuProcessor doesn't accept necessary sub keys

Thorben Nissen CR +2 V +2 Easy +8 −0 updated 10/20/17, 14:19

Commit message

Adds subproperty keys for levels, expandAll, includeSpacer and
titleField to $allowedConfigurationKeys.
Adds the subproperty keys also $removeConfigurationKeysForHmenu.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benjamin Kott +1
  • Verified V +2
    • Susi Moog +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Thorben Nissen uploaded patch set 1 10/19/17, 08:35

  2. Tymoteusz Motylewski commented on patch set 1 10/19/17, 08:39

    Hi Can you give some examples how to test it?
  3. TYPO3com voted on patch set 1 V +1 10/19/17, 08:44 Completed build in 09m 30s on Thu, 19 Oct, 10:44 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15793

  4. Thorben Nissen commented on patch set 1 10/19/17, 08:45

    Oh, for sure. Try that example: dataProcessing { 10 = TYPO3\CMS\Frontend\DataProcessing\MenuProcessor 10 { levels { field = someLevelFieldFromTheRecord ifEmpty = 1 } } } The level field is of course a custom field we added especially for one project, but I think, there are more use cases for this change.
  5. Benjamin Kott commented on patch set 1 CR -1 10/20/17, 12:09

    This is clearly a feature for me, this means we need a feature RST and proper documentation for this. Also we cannot backport this to 8.7.
  6. Thorben Nissen commented on patch set 1 10/20/17, 12:22

    @Benjamin: Of course, this could be seen as a feature, because it ads or extends the functionality. But it could also be seen as a bugfix, as the values are already processed using stdWrap logic, but the necessary sub properties are not allowed.
  7. Benjamin Kott commented on patch set 1 CR +1 V +1 10/20/17, 14:16

    @Thorben talked to mattes and susi about this, and we agreed on defining this as "impediment" so we can also backport this even it adds new functionality
  8. Susi Moog voted on patch set 1 CR +2 V +2 10/20/17, 14:19

  9. Gerrit merged patch set 1 10/20/17, 14:19

  10. Susi Moog commented on patch set 2 10/20/17, 14:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 16cdb66ccd840e592bb9545e9f39e8d2d9e757b3