Review main Merged

54445[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable

Susi Moog CR +2 V +2 Normal +131 −38 updated 10/19/17, 21:28

Commit message

Add new tests for fetchPagesWithVersionsInTable and correct comments.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Susi Moog uploaded patch set 1 10/19/17, 12:51

  2. Susi Moog uploaded patch set 2 10/19/17, 12:55

  3. Susi Moog uploaded patch set 3 10/19/17, 12:57

  4. Oliver Hader voted on patch set 3 CR +1 10/19/17, 12:58

  5. TYPO3com voted on patch set 1 V +1 10/19/17, 13:03 Completed build in 11m 15s on Thu, 19 Oct, 03:03 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15795

  6. TYPO3com voted on patch set 2 V +1 10/19/17, 13:06 Completed build in 10m 11s on Thu, 19 Oct, 03:06 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15796

  7. TYPO3com voted on patch set 3 V +1 10/19/17, 13:08 Completed build in 10m 17s on Thu, 19 Oct, 03:08 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15797

  8. Oliver Hader voted on patch set 3 V +1 10/19/17, 13:48

  9. Oliver Hader voted on patch set 3 CR +2 V +2 10/19/17, 21:27

  10. Gerrit merged patch set 3 10/19/17, 21:27

  11. Oliver Hader commented on patch set 4 10/19/17, 21:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 66e63dd200143391a7a904774055165798ae17a2