Review main Merged

54449[FEATURE] TCA: Allow label in palette array

Christian Kuhn CR +2 V +2 Hard +650 −323 updated 12/19/17, 12:06

Commit message

Allow 'label' within the 'palettes' array in TCA next
to 'showitem'. This defines a default label rendered as
the palette label in FormEngine if not overridden in
a 'types' definition like '--palette--;labelReference;thePalette'.

The patch introduces this feature in PaletteAndSingleContainer
of FormEngine code and adapts core TCA definitions to introduce
the default labels for palettes.

This makes the 'types' definitions shorter and much better readable
and gives the core an opportunity to steer the labels for palettes
which are often re-used by extension authors.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Benjamin Kott +1
  • Verified V +2
    • Benni Mack +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1215

  1. Christian Kuhn uploaded patch set 1 10/19/17, 23:05

  2. TYPO3com voted on patch set 1 V -1 10/19/17, 23:15 Completed build in 10m 15s on Fri, 20 Oct, 01:15 AM Test Summary: 2 of 57139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15809

  3. TYPO3com voted on patch set 1 V +1 10/20/17, 00:16 Completed build in 1h 21m 02s on Fri, 20 Oct, 02:16 AM Test Summary: 56780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15809

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 10/20/17, 10:57

  5. Wouter Wolters commented on patch set 1 10/20/17, 12:15

    PaletteAndSingleContainer.php:121

    === null instead of is_null. is_null is slower :)
  6. Christian Kuhn commented on patch set 2 10/20/17, 12:18

    Published edit on patch set 1.
  7. Benjamin Kott voted on patch set 2 CR +1 V +1 10/20/17, 12:19

  8. TYPO3com voted on patch set 2 V +1 10/20/17, 12:28 Completed build in 09m 51s on Fri, 20 Oct, 02:28 PM Test Summary: 56780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15827

  9. Wouter Wolters voted on patch set 2 CR +1 10/20/17, 12:29

  10. Benni Mack voted on patch set 2 CR +2 V +2 10/20/17, 12:50

  11. Gerrit merged patch set 2 10/20/17, 12:50

  12. Stephan Großberndt commented on patch set 3 12/18/17, 15:58

    Post -1

    pages.php:987

    The labels for 'shortcut' to 'external' were introduced here and do not exist in LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf It seems like a duplication of the doktypes though so I am not sure which would be the correct labels to set here.

    pages_language_overlay.php:399

    Same here but its the same labels.
  13. Stephan Großberndt commented on patch set 3 12/18/17, 16:04

    Found this due to Cedric Ziels awesome TYPO3 CMS Plugin for PHPStorm by the way.. https://github.com/cedricziel/idea-php-typo3-plugin
  14. Stephan Großberndt commented on patch set 3 12/18/17, 16:09

    sys_workspace.php:290

    The labels added here are not defined either
  15. Stephan Großberndt commented on patch set 3 12/19/17, 12:06

    The labels were just moved in this change, not introduced, but they are missing anyway. I created https://forge.typo3.org/issues/83388 for this.