54449[FEATURE] TCA: Allow label in palette array
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Benjamin Kott +1
-
Verified V +2
- Benni Mack +2
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php1+9 −1
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.phpnew+194 −0
- typo3/sysext/core/Configuration/TCA/pages.php1+103 −78
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+10 −6
- typo3/sysext/core/Documentation/Changelog/master/Feature-82826-TCAAllowLabelInPalettesArray.rstnew+61 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+3 −3
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+5 −5
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php+30 −23
- typo3/sysext/fluid_styled_content/Documentation/AddingYourOwnContentElements/Index.rst+5 −5
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+5 −5
- typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php1+59 −47
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+160 −147
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php1+6 −3
Review log 1215
-
Christian Kuhn uploaded patch set 1 10/19/17, 23:05
-
TYPO3com voted on patch set 1 V -1 10/19/17, 23:15 Completed build in 10m 15s on Fri, 20 Oct, 01:15 AM Test Summary: 2 of 57139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15809
-
TYPO3com voted on patch set 1 V +1 10/20/17, 00:16 Completed build in 1h 21m 02s on Fri, 20 Oct, 02:16 AM Test Summary: 56780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15809
-
Benjamin Kott voted on patch set 1 CR +1 V +1 10/20/17, 10:57
-
Wouter Wolters commented on patch set 1 10/20/17, 12:15
-
Christian Kuhn commented on patch set 2 10/20/17, 12:18
Published edit on patch set 1. -
Benjamin Kott voted on patch set 2 CR +1 V +1 10/20/17, 12:19
-
TYPO3com voted on patch set 2 V +1 10/20/17, 12:28 Completed build in 09m 51s on Fri, 20 Oct, 02:28 PM Test Summary: 56780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15827
-
Wouter Wolters voted on patch set 2 CR +1 10/20/17, 12:29
-
Benni Mack voted on patch set 2 CR +2 V +2 10/20/17, 12:50
-
Gerrit merged patch set 2 10/20/17, 12:50
-
Stephan Großberndt commented on patch set 3 12/18/17, 15:58
Post -1pages.php:987The labels for 'shortcut' to 'external' were introduced here and do not exist in LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf It seems like a duplication of the doktypes though so I am not sure which would be the correct labels to set here.pages_language_overlay.php:399Same here but its the same labels. -
Stephan Großberndt commented on patch set 3 12/18/17, 16:04
Found this due to Cedric Ziels awesome TYPO3 CMS Plugin for PHPStorm by the way.. https://github.com/cedricziel/idea-php-typo3-plugin -
Stephan Großberndt commented on patch set 3 12/18/17, 16:09
sys_workspace.php:290The labels added here are not defined either -
Stephan Großberndt commented on patch set 3 12/19/17, 12:06
The labels were just moved in this change, not introduced, but they are missing anyway. I created https://forge.typo3.org/issues/83388 for this.
PaletteAndSingleContainer.php:121