Review main Merged

54450[BUGFIX] Install tool extension scanner .rst file core version

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/20/17, 10:41

Commit message

The core version indicator in the extension scanner of the install
tool on reST files is broken on windows OS since path is split by
/ instead of \. Use DIRECTORY_SEPARATOR to fix this.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/20/17, 10:01

  2. Wouter Wolters voted on patch set 1 CR +1 10/20/17, 10:11

  3. TYPO3com voted on patch set 1 V +1 10/20/17, 10:11 Completed build in 10m 24s on Fri, 20 Oct, 12:11 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15810

  4. Susi Moog voted on patch set 1 CR +1 V +1 10/20/17, 10:12

  5. Christian Kuhn commented on patch set 1 10/20/17, 10:16

    susi verified this fixes the issue on windows.
  6. Benni Mack voted on patch set 1 CR +2 V +2 10/20/17, 10:41

  7. Gerrit merged patch set 1 10/20/17, 10:41