Review main Merged

54452[TASK] Popup file id on the right side of "File selector"

Gianluigi Martino CR +2 V +2 Easy +2 −2 updated 02/11/18, 00:36

Commit message

With this patch on the right side of the "File selector" window a popup
with the file id is showing hovering the file icon. The file size was
moved to the popup hovering the title.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Mathias Schreiber +1
    • Benni Mack +1
  • Verified V +2
    • Benjamin Kott +2
    • Mathias Schreiber +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Gianluigi Martino uploaded patch set 1 10/20/17, 10:35

  2. TYPO3com voted on patch set 1 V -1 10/20/17, 10:36 Completed build in 08s on Fri, 20 Oct, 12:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15814

  3. Gianluigi Martino commented on patch set 2 10/20/17, 10:42

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 10/20/17, 10:55 Completed build in 12m 18s on Fri, 20 Oct, 12:55 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15816

  5. Benjamin Kott commented on patch set 2 CR -2 10/20/17, 11:15

    can you explain please what the usecase of the id would be, it seems to be not very useful to editors since it cannot be used anywhere at all.
  6. Gianluigi Martino commented on patch set 2 10/20/17, 11:44

    What is the usecase of have two times the title? if i search a file with title "2017" and file selector find ten files, if i know the id of the file i know witch file is is as example.
  7. Mathias Schreiber updated the commit message in patch set 3 02/11/18, 00:28

  8. Benjamin Kott voted on patch set 2 CR 0 02/11/18, 00:28

  9. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/11/18, 00:28

  10. Benni Mack voted on patch set 3 V +1 CR +1 02/11/18, 00:35

  11. TYPO3com voted on patch set 3 V +1 02/11/18, 00:36 Completed build in 08m 20s on Sun, 11 Feb, 01:36 AM Test Summary: 30512 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19332

  12. Benjamin Kott voted on patch set 3 V +2 CR +2 02/11/18, 00:36

  13. Benjamin Kott merged patch set 4 02/11/18, 00:36