54455[!!!][TASK] Scheduler: Drop "use atd" based execution
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Neufeind +1
-
Verified V +2
- Andreas Kienast +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82832-UseAtDaemonDroppedFromScheduler.rstnew+37 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+0 −4
- typo3/sysext/scheduler/Classes/Scheduler.php+0 −72
- typo3/sysext/scheduler/Resources/Private/Language/locallang_em.xlf+0 −3
- typo3/sysext/scheduler/ext_conf_template.txt+0 −3
Review log 68
-
Christian Kuhn uploaded patch set 1 10/20/17, 11:14
-
Christian Kuhn commented on patch set 1 10/20/17, 11:22
Reasons: * It was never documented * atd is not a default daemon on systems and needs manual install and config * there is not a single document in the net about this feature, everyone simply talks about cron * it has never been fully integrated into the backend scheduler module, buttons like "execute on next cron run" are misleading -
Christian Kuhn commented on patch set 1 10/20/17, 11:23
* the implementation uses shell_exec() directly which is not the way core should do that -
TYPO3com voted on patch set 1 V -1 10/20/17, 11:27 Completed build in 12m 14s on Fri, 20 Oct, 01:27 PM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15817
-
TYPO3com voted on patch set 1 V +1 10/20/17, 11:30 Completed build in 27m 56s on Fri, 20 Oct, 01:30 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15817
-
Stefan Neufeind commented on patch set 1 CR +1 V +1 10/20/17, 12:23
Sad to hear an alternative to cron is not of interest. But okay then. Visually verified against patchset when the feature was added, so we are sure all parts added for that feature are removed (https://review.typo3.org/9177). -
Andreas Kienast voted on patch set 1 CR +2 V +2 10/20/17, 12:37
-
Gerrit merged patch set 1 10/20/17, 12:37