54459[TASK] Update Symfony packages to latest releases
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1215
-
Helmut Hummel uploaded patch set 1 10/20/17, 12:57
-
TYPO3com voted on patch set 1 V -1 10/20/17, 13:08 Completed build in 10m 47s on Fri, 20 Oct, 03:08 PM Test Summary: 6 of 57959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1100
-
Helmut Hummel updated the commit message in patch set 2 10/20/17, 14:02
-
TYPO3com voted on patch set 2 V -1 10/20/17, 14:16 Completed build in 14m 13s on Fri, 20 Oct, 04:16 PM Test Summary: 6 of 57959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1102
-
Susi Moog commented on patch set 2 10/20/17, 14:18
YamlParser has changed the exceptions it throws, that's why the tests fail. we should check our code whether or not we depend on those specific exceptions. -
Helmut Hummel uploaded patch set 3 10/20/17, 14:26
-
Helmut Hummel commented on patch set 3 10/20/17, 14:33
seems the parser is more graceful with slightly invalid yaml. I changed the to be failing yaml a bit. -
Helmut Hummel commented on patch set 3 10/20/17, 14:34
composer.json:64that is totally not related, but still a valid change. I can create a separate commit if desired -
Helmut Hummel commented on patch set 3 10/20/17, 14:35
the thrown exception is still the same btw. -
TYPO3com voted on patch set 3 V +1 10/20/17, 14:39 Completed build in 13m 01s on Fri, 20 Oct, 04:39 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1104
-
Benni Mack commented on patch set 3 10/20/17, 15:22
Hmm... uncool. Basically it means that EXT:form was not Symfony 3.3 compatible - meaning Symfony had a breaking change OR EXT:form did not follow the proper API (handling exceptions) -
Benni Mack voted on patch set 3 CR +1 V +1 10/20/17, 15:25
-
Susi Moog commented on patch set 3 CR +2 V +2 10/20/17, 15:44
as long as the parser gets less strict and we only rely on the parser and not on the format ourselves, all is fine I guess. -
Gerrit merged patch set 3 10/20/17, 15:44
-
Helmut Hummel commented on patch set 4 10/20/17, 17:57
Thanks!