Review TYPO3_8-7 Merged

54464[BUGFIX] Do not force content_fallback to default page language

Susi Moog CR +2 V +2 Easy +46 −4 updated 10/25/17, 05:37

Commit message

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Susi Moog commented on patch set 1 10/23/17, 07:40

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/23/17, 07:54 Completed build in 13m 41s on Mon, 23 Oct, 09:54 AM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1111

  3. Susi Moog commented on patch set 1 CR +2 V +2 10/25/17, 05:37

    clean backport
  4. Gerrit merged patch set 1 10/25/17, 05:37