54468[TASK] Make SVG category tree use JS Icon API
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1723
-
Tymoteusz Motylewski uploaded patch set 1 10/24/17, 11:16
-
TYPO3com voted on patch set 1 V -1 10/24/17, 11:16 Completed build in 08s on Tue, 24 Oct, 01:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15857
-
Tymoteusz Motylewski updated the commit message in patch set 2 10/24/17, 11:16
-
TYPO3com voted on patch set 2 V -1 10/24/17, 11:17 Completed build in 08s on Tue, 24 Oct, 01:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15858
-
Tymoteusz Motylewski uploaded patch set 3 10/24/17, 11:18
-
Tymoteusz Motylewski updated the commit message in patch set 4 10/24/17, 11:27
-
TYPO3com voted on patch set 3 V -1 10/24/17, 11:28 Completed build in 09m 59s on Tue, 24 Oct, 01:28 PM Test Summary: 3 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15859
-
TYPO3com voted on patch set 4 V -1 10/24/17, 11:36 Completed build in 08m 47s on Tue, 24 Oct, 01:36 PM Test Summary: 1 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15860
-
Benni Mack commented on patch set 4 10/25/17, 04:47
approach seems very reasonable and cleaner than before. -
Tymoteusz Motylewski uploaded patch set 5 10/31/17, 15:39
-
TYPO3com voted on patch set 5 V +1 10/31/17, 15:50 Completed build in 10m 40s on Tue, 31 Oct, 04:50 PM Test Summary: 56936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15943
-
Tymoteusz Motylewski commented on patch set 5 11/02/17, 10:12
SvgTree.js:259Icon API is not capable of retruning just svg without wrapping it in html. this regex works around it.SvgTree.js:260if somebody knows a better solution here, it would be great. Now, an update on a tree is called every time a new icon is fetched (so the UI is updated). In theory we could save all promises returned by getIcon to an array and run update as callback after all promises are resolved. But I did not manage to get it working correctly. Hopefully update() is cheap, and we do one getIcon call per icon name, so it does not do that much harm. -
Tymoteusz Motylewski commented on patch set 5 11/02/17, 10:15
Btw in my tests with 300 categories, the response size went down from 240KB to 50KB -
Frans Saris commented on patch set 5 11/02/17, 12:04
Does this also work with non svg images? -
Tymoteusz Motylewski commented on patch set 5 11/02/17, 12:16
nop, only svg is allowed -
Benni Mack voted on patch set 5 CR +1 V +1 11/02/17, 15:16
-
Tymoteusz Motylewski rebased onto patch set 6 11/02/17, 15:23
-
Tymoteusz Motylewski commented on patch set 6 11/02/17, 15:25
rebased by mistake -
TYPO3com voted on patch set 6 V +1 11/02/17, 15:34 Completed build in 10m 26s on Thu, 2 Nov, 04:34 PM Test Summary: 56930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15997
-
Benni Mack voted on patch set 6 CR +1 V +1 11/02/17, 15:35
-
Susi Moog voted on patch set 6 CR +2 V +2 11/02/17, 16:51
-
Gerrit merged patch set 6 11/02/17, 16:51
-
Tymoteusz Motylewski commented on patch set 7 11/02/17, 19:39
thanks!