54470[BUGFIX] Avoid race condition in JS Icon API
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Stefan Neufeind +1
- Andreas Kienast +1
- Andreas Wolf +1
-
Verified V +2
- Frank Nägler +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Tymoteusz Motylewski uploaded patch set 1 10/24/17, 19:32
-
TYPO3com voted on patch set 1 V +1 10/24/17, 19:40 Completed build in 08m 34s on Tue, 24 Oct, 09:40 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15862
-
Tymoteusz Motylewski updated the commit message in patch set 2 10/24/17, 19:46
-
TYPO3com voted on patch set 2 V +1 10/24/17, 19:55 Completed build in 08m 50s on Tue, 24 Oct, 09:55 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15863
-
Andreas Wolf commented on patch set 2 CR +1 10/26/17, 18:46
Looks good, using a promise seems a lot more sensible than the callback voodoo of jQuery… -
Andreas Kienast voted on patch set 2 CR +1 10/27/17, 07:49
-
Frank Nägler voted on patch set 2 CR +1 V +1 10/27/17, 12:12
-
Stefan Neufeind commented on patch set 2 CR +1 V +1 10/27/17, 14:27
I like the solution and it works for me. Number of requests is reduced, as advertised. Nice one! -
Frank Nägler voted on patch set 2 CR +2 V +2 10/27/17, 14:35
-
Gerrit merged patch set 2 10/27/17, 14:35
-
Frank Nägler commented on patch set 3 10/27/17, 14:35
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3c698f3b9f303129324825674bf45c338fca7af8