Review main Merged Breaking

54471[!!!][BUGFIX] Throw exception on invalid charset

Mathias Brodala CR +2 V +2 Normal +66 −3 updated 10/30/17, 16:10

Commit message

This gives users a clear hint if e.g. config.metaCharset contains
an invalid value instead of showing a blank page.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wolfgang Klinger +1
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Stefan Neufeind +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1820

  1. Mathias Brodala uploaded patch set 1 10/25/17, 07:46

  2. TYPO3com voted on patch set 1 V +1 10/25/17, 07:55 Completed build in 09m 14s on Wed, 25 Oct, 09:55 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15864

  3. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/25/17, 08:46

  4. Wolfgang Klinger voted on patch set 1 CR +1 10/25/17, 15:06

  5. Stefan Neufeind voted on patch set 1 CR +1 10/25/17, 20:19

  6. Stefan Neufeind voted on patch set 1 V +1 10/25/17, 20:28

  7. Stefan Neufeind commented on patch set 1 10/25/17, 20:28

    But imho we should only add that exception to master, not 8.7 anymore - just to be sure not to break installations?
  8. Mathias Brodala commented on patch set 1 10/26/17, 07:17

    > But imho we should only add that exception to master, not 8.7 > anymore - just to be sure not to break installations? Benni mentioned this already and suggested a log entry here. For the mentioned case there wouldn't be an issue since instead of an empty page you'd now get a descriptive error message. For the case 3rd party code uses the CharsetConverter directly, this would indeed be breaking however.
  9. Frank Nägler commented on patch set 1 CR -1 10/27/17, 12:46

    This is a breaking change. 1) imho no way for 8.7 branch 2) the patch change a public method with @access private, but a lot other public methods like utf8_encode will cal initCharset and this exception is not catched. 3) Need a rst file in any case
  10. Mathias Brodala commented on patch set 1 10/27/17, 12:55

    > This is a breaking change. > 1) imho no way for 8.7 branch What do you think about a log message for v8? > 2) the patch change a public method with @access private, but a lot > other public methods like utf8_encode will cal initCharset and this > exception is not catched. This is intentional since catching the exception wouldn't help since you won't be notified about your error. > 3) Need a rst file in any case Absorlutely correct, I'll add one.
  11. Frank Nägler commented on patch set 1 10/27/17, 13:00

    logging is fine, but no exception which could break an installation. example could be an extension which expects false in this case to handle a wrong locale, this would kill an instace with a core update, so that is the reason why I say: no way for v8. logging is not a problem, I guess. And the exception for master is also fine with the rst file.
  12. Mathias Brodala uploaded patch set 2 10/27/17, 13:08

  13. TYPO3com voted on patch set 2 V +1 10/27/17, 13:17 Completed build in 08m 46s on Fri, 27 Oct, 03:17 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15882

  14. Frank Nägler commented on patch set 2 CR +1 10/27/17, 14:01

    thanks for the update, as mentioned no exception in the backport, but I am fine for master.
  15. Wolfgang Klinger voted on patch set 2 CR +1 10/27/17, 16:53

  16. Riccardo De Contardi commented on patch set 2 V +1 10/29/17, 09:38

    verified on master
  17. Wouter Wolters voted on patch set 2 CR +1 10/30/17, 09:55

  18. Stefan Neufeind voted on patch set 2 CR +2 V +2 10/30/17, 16:07

  19. Gerrit merged patch set 2 10/30/17, 16:07

  20. Stefan Neufeind commented on patch set 3 10/30/17, 16:10

    backport: I'll be in contact with Mathias about how we'll do the backport with logging.