Review main Merged

54473[BUGFIX] Fix foreign_table_where GROUP BY handling

Wolfgang Klinger CR +2 V +2 Easy +4 −3 updated 10/30/17, 20:05

Commit message

Unpack the array elements before passing them on

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Wolfgang Klinger uploaded patch set 1 10/25/17, 10:39

  2. Mathias Brodala commented on patch set 1 10/25/17, 10:49

    AbstractItemProvider.php:961

    Why not $queryBuilder->addGroupBy(...$foreignTableClauseArray['GROUPBY'])?
  3. TYPO3com voted on patch set 1 V -1 10/25/17, 10:50 Completed build in 10m 54s on Wed, 25 Oct, 12:50 PM Test Summary: 6 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15866

  4. Wolfgang Klinger uploaded patch set 2 10/25/17, 11:02

  5. TYPO3com voted on patch set 2 V -1 10/25/17, 11:12 Completed build in 10m 11s on Wed, 25 Oct, 01:12 PM Test Summary: 6 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15867

  6. Wolfgang Klinger uploaded patch set 3 10/25/17, 11:36

  7. TYPO3com voted on patch set 3 V +1 10/25/17, 11:45 Completed build in 09m 11s on Wed, 25 Oct, 01:45 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15868

  8. Mathias Brodala voted on patch set 3 CR +1 10/25/17, 11:58

  9. Markus Klein voted on patch set 3 CR +1 V +1 10/25/17, 14:15

  10. Wolfgang Klinger uploaded patch set 4 10/27/17, 17:12

  11. TYPO3com voted on patch set 4 V +1 10/27/17, 17:21 Completed build in 08m 42s on Fri, 27 Oct, 07:21 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15891

  12. Markus Klein voted on patch set 4 CR +1 V +1 10/27/17, 17:40

  13. Wouter Wolters voted on patch set 4 CR +1 10/27/17, 18:46

  14. Wouter Wolters voted on patch set 4 CR +2 V +2 10/30/17, 20:04

  15. Gerrit merged patch set 4 10/30/17, 20:04

  16. Wouter Wolters commented on patch set 5 10/30/17, 20:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5a942266ff099f55dd8629c6ab94c8d46d404c6e