Review TYPO3_8-7 Merged

54478[BUGFIX] Allow multiline strings in foreign_table_where

Georg Ringer CR +2 V +2 Easy +8 −4 updated 10/27/17, 12:22

Commit message

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Georg Ringer commented on patch set 1 10/26/17, 14:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/26/17, 14:16 Completed build in 15m 07s on Thu, 26 Oct, 04:16 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1115

  3. Andreas Kienast commented on patch set 1 10/26/17, 14:27

    TcaSelectItemsTest.php:1800

    Does it make sense to test both cases: with line breaks and without line breaks?
  4. Markus Klein commented on patch set 1 10/26/17, 16:14

    TcaSelectItemsTest.php:1800 Reply

    I would say it's enough to test the "extended" version here.
  5. Markus Klein updated the commit message in patch set 2 10/26/17, 16:15

  6. Markus Klein voted on patch set 2 CR +1 V +1 10/26/17, 16:15

  7. TYPO3com voted on patch set 2 V +1 10/26/17, 16:27 Completed build in 12m 39s on Thu, 26 Oct, 06:27 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1116

  8. Frank Nägler voted on patch set 2 CR +2 V +2 10/27/17, 12:22

  9. Gerrit merged patch set 2 10/27/17, 12:22