Review main Merged

54479[BUGFIX] Only fetch fileReferences from localized table if column exist

Benjamin Kott CR +2 V +2 Easy +5 −0 updated 10/27/17, 15:40

Commit message

Only if a localized table also contains the requested column for file
references it will overlay the previous generated resultset.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1216

  1. Benjamin Kott uploaded patch set 1 10/26/17, 15:55

  2. TYPO3com voted on patch set 1 V +1 10/26/17, 16:05 Completed build in 09m 57s on Thu, 26 Oct, 06:05 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15876

  3. Benjamin Kott updated the commit message in patch set 2 10/26/17, 16:10

  4. TYPO3com voted on patch set 2 V +1 10/26/17, 16:19 Completed build in 09m 14s on Thu, 26 Oct, 06:19 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15877

  5. Oliver Klee commented on patch set 2 10/26/17, 17:00

    Can we unit-test this?
  6. Benni Mack commented on patch set 3 10/26/17, 18:30

    Published edit on patch set 2.
  7. Benni Mack voted on patch set 3 CR +1 10/26/17, 18:30

  8. TYPO3com voted on patch set 3 V +1 10/26/17, 18:39 Completed build in 09m 34s on Thu, 26 Oct, 08:39 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15878

  9. Benjamin Kott commented on patch set 3 10/26/17, 18:46

    can be tested again current master ob the bootstrap_package, with the icons for navigation entries
  10. Markus Klein voted on patch set 3 CR +1 V +1 10/26/17, 22:57

  11. Frank Nägler updated the commit message in patch set 4 10/27/17, 12:33

  12. Frank Nägler commented on patch set 4 CR +1 V +1 10/27/17, 12:34

    After a talk to Benji, we will not backport this fix top v7. but is not heavy enough and is not a priority bugfix.
  13. TYPO3com voted on patch set 4 V +1 10/27/17, 12:43 Completed build in 09m 35s on Fri, 27 Oct, 02:43 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15881

  14. Markus Klein voted on patch set 4 CR +2 V +2 10/27/17, 15:25

  15. Gerrit merged patch set 4 10/27/17, 15:25

  16. Markus Klein commented on patch set 5 10/27/17, 15:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 04f09fb6c1bae8c4d942c18dbf3adcfa34676f6e