54483[BUGFIX] Do not rawurlencode record titles using label_alt and type=group
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Mathias Schreiber +1
-
Verified V +2
- Susi Moog +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Stephan Großberndt uploaded patch set 1 10/27/17, 13:01
-
TYPO3com voted on patch set 1 V +1 10/27/17, 13:06 Completed build in 04m 10s on Fri, 27 Oct, 03:06 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1177
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 08:30
-
Mathias Schreiber voted on patch set 1 V +1 CR +1 02/04/18, 11:14
-
Timo Pfeffer voted on patch set 1 CR +1 02/05/18, 06:34
-
Oliver Hader commented on patch set 1 CR -1 02/06/18, 21:45
RelationHandler is the wrong approach here and might cause side effects. Using rawurlencode there was base on using this information in JavaScript handling in the past. In v8 this has been solved differently (without removing the rawurlencode()). The initial patch in https://review.typo3.org/#/c/50959/1/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php seemed to be correct to me. FormEngine is preparing the record data for the fields types to be rendered - in this scenario however, that information is used to render the title and not the field type. That's why I consider the change in TcaRecordTitle correct. -
Oliver Hader uploaded patch set 2 02/06/18, 21:56
-
Mathias Schreiber voted on patch set 2 V +1 CR +1 02/06/18, 21:57
-
TYPO3com voted on patch set 2 V +1 02/06/18, 22:01 Completed build in 04m 53s on Tue, 6 Feb, 11:01 PM Test Summary: 49124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1351
-
Susi Moog commented on patch set 2 V +2 CR +2 02/06/18, 22:01
for 7.6 this solution is ok, in 8 it's solved nicer. -
Susi Moog merged patch set 3 02/06/18, 22:01