Review main Merged

54485[BUGFIX] Fix usages of config.additionalHeaders

Markus Klein CR +2 V +2 Easy +12 −7 updated 10/30/17, 09:54

Commit message

Update some internal usages of config.additionalHeaders in tests
and other places to use the correct new syntax.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1114

  1. Markus Klein uploaded patch set 1 10/27/17, 13:52

  2. Markus Klein uploaded patch set 2 10/27/17, 13:54

  3. Mathias Brodala voted on patch set 2 CR +1 10/27/17, 13:59

  4. TYPO3com voted on patch set 1 V +1 10/27/17, 14:06 Completed build in 13m 28s on Fri, 27 Oct, 04:06 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15883

  5. TYPO3com voted on patch set 2 V +1 10/27/17, 14:06 Completed build in 12m 21s on Fri, 27 Oct, 04:06 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15884

  6. Andreas Kienast voted on patch set 2 CR +1 10/27/17, 14:16

  7. Benni Mack voted on patch set 2 CR +2 V +1 10/27/17, 15:07

  8. Georg Ringer commented on patch set 2 10/27/17, 17:17

    can we please get a bit more info in the commit msg? thx
  9. Markus Klein updated the commit message in patch set 3 10/27/17, 17:29

  10. TYPO3com voted on patch set 3 V +1 10/27/17, 17:40 Completed build in 10m 10s on Fri, 27 Oct, 07:40 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15892

  11. Wouter Wolters voted on patch set 3 CR +1 10/27/17, 18:46

  12. Wouter Wolters voted on patch set 3 V +1 10/30/17, 09:52

  13. Benni Mack voted on patch set 3 CR +2 V +2 10/30/17, 09:54

  14. Gerrit merged patch set 3 10/30/17, 09:54