Review TYPO3_8-7 Merged

54486[BUGFIX] Avoid race condition in JS Icon API

Frank Nägler CR +2 V +2 Easy +12 −13 updated 10/27/17, 15:16

Commit message

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Review

  • Code review CR +2
    • Frank Nägler +2
  • Verified V +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Frank Nägler commented on patch set 1 10/27/17, 14:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/27/17, 14:50 Completed build in 14m 28s on Fri, 27 Oct, 04:50 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1121

  3. Stefan Neufeind voted on patch set 1 V +1 10/27/17, 14:54

  4. Frank Nägler voted on patch set 1 CR +2 V +2 10/27/17, 15:16

  5. Gerrit merged patch set 1 10/27/17, 15:16