Review main Merged Breaking

54489[!!!][TASK] Remove DB field pages.no_cache

Benni Mack CR +2 V +2 Normal +48 −61 updated 10/30/17, 07:22

Commit message

Having an option to completely disable the page rendering
cache available per page for editors is a real risk. This
option is largely hard to understand for an editor,
or an admin.

Integrators can still use `config.no_cache = 1` in
TypoScript on a condition basis to achieve the same
result.

Review

  • Code review CR +2
    • Susi Moog +2
    • Henning Liebe +1
  • Verified V +2
    • Susi Moog +2
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1316

  1. Benni Mack uploaded patch set 1 10/27/17, 19:24

  2. TYPO3com voted on patch set 1 V +1 10/27/17, 19:33 Completed build in 08m 45s on Fri, 27 Oct, 09:33 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15893

  3. Henning Liebe voted on patch set 1 CR +1 V +1 10/27/17, 20:52

  4. Benni Mack commented on patch set 1 CR -2 10/29/17, 11:09

    RST missing
  5. Benni Mack uploaded patch set 2 10/29/17, 11:41

  6. Benni Mack voted on patch set 2 CR 0 10/29/17, 11:42

  7. TYPO3com voted on patch set 2 V +1 10/29/17, 11:50 Completed build in 09m 12s on Sun, 29 Oct, 12:50 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15900

  8. Riccardo De Contardi commented on patch set 2 10/29/17, 14:57

    I guess that the documentation should read: `SELECT uid, pid, title, no_cache FROM pages WHERE deleted=0 AND pid>=0;`
  9. Riccardo De Contardi commented on patch set 2 10/29/17, 15:24

    inserted as comment

    Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst

    `SELECT uid, pid, title, no_cache FROM pages WHERE deleted=0 AND pid>=0;`
  10. Riccardo De Contardi commented on patch set 2 10/29/17, 15:25

    comment in wrong position (sorry)

    Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst Reply

    Done

    Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst:28

    `SELECT uid, pid, title,no_cache FROM pages WHERE deleted=0 AND pid>=0;`
  11. Benni Mack commented on patch set 3 10/30/17, 05:18

    Published edit on patch set 2.
  12. TYPO3com voted on patch set 3 V +1 10/30/17, 05:27 Completed build in 08m 45s on Mon, 30 Oct, 06:27 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15909

  13. Susi Moog voted on patch set 3 CR +1 V +1 10/30/17, 06:25

  14. Henning Liebe voted on patch set 3 CR +1 V +1 10/30/17, 07:21

  15. Susi Moog voted on patch set 3 CR +2 V +2 10/30/17, 07:22

  16. Gerrit merged patch set 3 10/30/17, 07:22