54489[!!!][TASK] Remove DB field pages.no_cache
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Henning Liebe +1
-
Verified V +2
- Susi Moog +2
- Henning Liebe +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Configuration/TCA/pages.php+3 −15
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst3new+43 −0
- typo3/sysext/core/Resources/Private/Language/locallang_csh_pages.xlf+0 −16
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php+0 −10
- typo3/sysext/core/ext_tables.sql+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −4
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −9
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php+0 −3
- typo3/sysext/info/Classes/Controller/PageInformationController.php+0 −1
Review log 1316
-
Benni Mack uploaded patch set 1 10/27/17, 19:24
-
TYPO3com voted on patch set 1 V +1 10/27/17, 19:33 Completed build in 08m 45s on Fri, 27 Oct, 09:33 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15893
-
Henning Liebe voted on patch set 1 CR +1 V +1 10/27/17, 20:52
-
Benni Mack commented on patch set 1 CR -2 10/29/17, 11:09
RST missing -
Benni Mack uploaded patch set 2 10/29/17, 11:41
-
Benni Mack voted on patch set 2 CR 0 10/29/17, 11:42
-
TYPO3com voted on patch set 2 V +1 10/29/17, 11:50 Completed build in 09m 12s on Sun, 29 Oct, 12:50 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15900
-
Riccardo De Contardi commented on patch set 2 10/29/17, 14:57
I guess that the documentation should read: `SELECT uid, pid, title, no_cache FROM pages WHERE deleted=0 AND pid>=0;` -
Riccardo De Contardi commented on patch set 2 10/29/17, 15:24
inserted as commentBreaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst`SELECT uid, pid, title, no_cache FROM pages WHERE deleted=0 AND pid>=0;` -
Riccardo De Contardi commented on patch set 2 10/29/17, 15:25
comment in wrong position (sorry)Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rstReplyDoneBreaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst:28`SELECT uid, pid, title,no_cache FROM pages WHERE deleted=0 AND pid>=0;` -
Benni Mack commented on patch set 3 10/30/17, 05:18
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 10/30/17, 05:27 Completed build in 08m 45s on Mon, 30 Oct, 06:27 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15909
-
Susi Moog voted on patch set 3 CR +1 V +1 10/30/17, 06:25
-
Henning Liebe voted on patch set 3 CR +1 V +1 10/30/17, 07:21
-
Susi Moog voted on patch set 3 CR +2 V +2 10/30/17, 07:22
-
Gerrit merged patch set 3 10/30/17, 07:22