Review main Merged

54494[BUGFIX] Validate page error handler result to report wrong configuration

Markus Klein CR +2 V +2 Easy +14 −6 updated 11/27/17, 22:09

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • Henning Liebe +1
  • Verified V +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2533

Show 68 earlier messages
  1. Markus Klein uploaded patch set 1 10/29/17, 17:05

  2. TYPO3com voted on patch set 1 V -1 10/29/17, 17:05 Completed build in 08s on Sun, 29 Oct, 06:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15903

  3. Markus Klein uploaded patch set 2 10/29/17, 17:07

  4. TYPO3com voted on patch set 2 V +1 10/29/17, 17:17 Completed build in 09m 20s on Sun, 29 Oct, 06:17 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15904

  5. Wouter Wolters voted on patch set 2 CR +1 10/30/17, 20:26

  6. Susi Moog voted on patch set 2 CR +1 11/02/17, 09:56

  7. Henning Liebe commented on patch set 2 V -1 11/06/17, 13:40

    TypoScriptFrontendController.php:2020

    Doesn't work for me because $report is always null. if $report is not initialized (as an array) GeneralUtility::getUrl will not add any informations to $report because of isset checks.
  8. Markus Klein commented on patch set 3 11/06/17, 13:46

    Published edit on patch set 2.
  1. TYPO3com voted on patch set 3 V +1 11/06/17, 13:55 Completed build in 08m 46s on Mon, 6 Nov, 02:55 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16118

  2. Henning Liebe uploaded patch set 4 11/06/17, 14:27

  3. TYPO3com voted on patch set 4 V -1 11/06/17, 14:36 Completed build in 08m 55s on Mon, 6 Nov, 03:36 PM Test Summary: 2 of 57109 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16121

  4. TYPO3com voted on patch set 4 V +1 11/06/17, 14:50 Completed build in 31m 31s on Mon, 6 Nov, 03:50 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16121

  5. Markus Klein commented on patch set 4 CR -1 11/06/17, 16:32

    TypoScriptFrontendController.php:2018

    Why did you change that? 'OK' is never set!

    TypoScriptFrontendController.php:2019

    thanks for fixing that!
  6. Markus Klein uploaded patch set 5 11/13/17, 12:45

  7. TYPO3com voted on patch set 5 V +1 11/13/17, 12:55 Completed build in 10m 12s on Mon, 13 Nov, 01:55 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16281

  8. Andreas Kienast commented on patch set 5 11/14/17, 14:05

    TypoScriptFrontendController.php:1967

    Should we add the "previous" argument with $e as value here?
  9. Markus Klein commented on patch set 6 11/14/17, 19:29

    Published edit on patch set 5.
  10. TYPO3com voted on patch set 6 V +1 11/14/17, 19:39 Completed build in 09m 14s on Tue, 14 Nov, 08:39 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16355

  11. Susi Moog voted on patch set 6 CR +1 11/16/17, 21:28

  12. Henning Liebe voted on patch set 6 CR +1 V +1 11/20/17, 08:46

  13. Jörg Bösche voted on patch set 6 CR +1 11/20/17, 10:12

  14. Stefan Neufeind voted on patch set 6 CR +1 11/20/17, 23:48

  15. Sebastian Hofer voted on patch set 6 CR +1 11/27/17, 19:27

  16. Susi Moog uploaded patch set 7 11/27/17, 20:47

  17. Susi Moog commented on patch set 7 11/27/17, 20:48

    In my case, error no in handler context was null, as the context is set by guzzle depending on the handler. Guzzle adds the http status code as exception code so we can use that instead.
  18. Markus Klein commented on patch set 7 11/27/17, 20:49

  19. TYPO3com voted on patch set 7 V +1 11/27/17, 20:58 Completed build in 11m 30s on Mon, 27 Nov, 09:58 PM Test Summary: 56814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16732

  20. Susi Moog voted on patch set 7 CR +1 V +1 11/27/17, 22:06

  21. Henning Liebe voted on patch set 7 CR +1 V +1 11/27/17, 22:07

  22. Stefan Neufeind voted on patch set 7 CR +1 V +1 11/27/17, 22:07

  23. Susi Moog voted on patch set 7 CR +2 V +2 11/27/17, 22:09

  24. Gerrit merged patch set 7 11/27/17, 22:09

  25. Susi Moog commented on patch set 8 11/27/17, 22:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 992a10b5d351c853bad53bbf0318f3814e2a0b47