Review main Merged

54495[BUGFIX] Set correct HTTP header when page access is denied

Markus Klein CR +2 V +2 Easy +46 −2 updated 11/28/17, 07:51

Commit message

Accessing an existing page with insufficient permissions should
not set a 404 header but a 403 header.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1114

  1. Markus Klein uploaded patch set 1 10/29/17, 17:37

  2. TYPO3com voted on patch set 1 V +1 10/29/17, 17:46 Completed build in 08m 41s on Sun, 29 Oct, 06:46 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15907

  3. Susi Moog voted on patch set 1 CR +1 10/30/17, 07:25

  4. Markus Klein uploaded patch set 2 10/30/17, 20:02

  5. TYPO3com voted on patch set 2 V +1 10/30/17, 20:16 Completed build in 14m 11s on Mon, 30 Oct, 09:16 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15923

  6. Georg Ringer commented on patch set 2 10/31/17, 08:27

    this adds a new property in install tool, an important rst is a must if you want to have backports or a feature.rst
  7. Benni Mack commented on patch set 2 CR +1 11/24/17, 21:20

    we should ad an important RST, really good improvement though!
  8. Markus Klein commented on patch set 2 CR -1 11/25/17, 18:19

    DefaultConfigurationDescription.yaml:356

    I dislike the name now reading that again. will change it
  9. Markus Klein uploaded patch set 3 11/27/17, 22:07

  10. TYPO3com voted on patch set 3 V +1 11/27/17, 22:22 Completed build in 14m 17s on Mon, 27 Nov, 11:22 PM Test Summary: 56814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16750

  11. Georg Ringer voted on patch set 3 CR +1 V +1 11/28/17, 06:22

  12. Wouter Wolters commented on patch set 3 11/28/17, 07:48

    Yesterday I was unable to have a good test scenario, my header stayed at 404
  13. Susi Moog commented on patch set 3 CR +2 V +2 11/28/17, 07:51

    (setting the value to empty results in 404, default is 403, overwriting works)
  14. Gerrit merged patch set 3 11/28/17, 07:51