54496[FEATURE] Allow nested GET-parameters for config.linkVars
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Sebastian Hofer +1
-
Verified V +2
- Susi Moog +2
- Sebastian Hofer +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1522
-
Markus Klein uploaded patch set 1 10/29/17, 18:35
-
TYPO3com voted on patch set 1 V -1 10/29/17, 18:44 Completed build in 09m 17s on Sun, 29 Oct, 07:44 PM Test Summary: 2 of 57217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15908
-
TYPO3com voted on patch set 1 V +1 10/30/17, 07:29 Completed build in 13h 03m 16s on Mon, 30 Oct, 08:29 AM Test Summary: 56858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15908
-
Susi Moog voted on patch set 1 CR +1 10/30/17, 07:30
-
Tymoteusz Motylewski commented on patch set 2 11/03/17, 21:31
Published edit on patch set 1. -
Tymoteusz Motylewski commented on patch set 2 11/03/17, 21:33
Feature-22439-AllowNestedGET-paramsInConfiglinkVars.rst:12Please add some more context to this information, so it's clear what is the purpose without having to check in TS reference what linkVars is used for. eg. "config.linkVarsFeature-22439-AllowNestedGET-paramsInConfiglinkVars.rst:19can we combine nesting with range (0-2)? can you please describe what how the GET param will look like? -
TYPO3com voted on patch set 2 V +1 11/03/17, 21:40 Completed build in 09m 05s on Fri, 3 Nov, 10:40 PM Test Summary: 56774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16060
-
Sebastian Hofer voted on patch set 2 CR +1 11/27/17, 20:09
-
Sebastian Hofer commented on patch set 3 11/27/17, 20:31
Published edit on patch set 2. -
Sebastian Hofer voted on patch set 3 CR +1 11/27/17, 20:31
-
TYPO3com voted on patch set 3 V -1 11/27/17, 20:48 Completed build in 17m 05s on Mon, 27 Nov, 09:48 PM Test Summary: 56688 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16729
-
Sebastian Hofer commented on patch set 3 CR 0 11/27/17, 22:11
Feature-22439-AllowNestedGET-paramsInConfiglinkVars.rst:21move to last line -
Sebastian Hofer commented on patch set 4 11/27/17, 22:12
Published edit on patch set 3. -
Markus Klein commented on patch set 5 11/27/17, 22:21
Published edit on patch set 4. -
TYPO3com voted on patch set 4 V +1 11/27/17, 22:34 Completed build in 21m 49s on Mon, 27 Nov, 11:34 PM Test Summary: 56838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16752
-
TYPO3com voted on patch set 5 V -1 11/27/17, 22:50 Completed build in 29m 09s on Mon, 27 Nov, 11:50 PM Test Summary: 56845 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16754
-
TYPO3com voted on patch set 5 V +1 11/28/17, 08:34 Completed build in 10h 41m 30s on Tue, 28 Nov, 09:34 AM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16754
-
Susi Moog voted on patch set 5 CR +1 V +1 11/28/17, 08:46
-
Sebastian Hofer voted on patch set 5 CR +1 11/28/17, 09:43
-
Sebastian Hofer voted on patch set 5 V +1 11/28/17, 10:25
-
Susi Moog voted on patch set 5 CR +2 V +2 11/28/17, 10:34
-
Gerrit merged patch set 5 11/28/17, 10:34