Review TYPO3_7-6 Merged

54497[BUGFIX] Show SQL errors during extension installation

Nicole Hummel CR +2 V +2 Normal +53 −5 updated 05/25/18, 12:23

Commit message

This patch shows collected SQL errors that occurred during an extension
installation as flash message.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Opitz +1
  • Verified V +2
    • Benni Mack +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1720

  1. Nicole Hummel uploaded patch set 1 10/29/17, 19:30

  2. TYPO3com voted on patch set 1 V +1 10/29/17, 19:35 Completed build in 04m 02s on Sun, 29 Oct, 08:35 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1178

  3. Wouter Wolters voted on patch set 1 CR +1 10/30/17, 10:15

  4. Alexander Opitz voted on patch set 1 CR +1 11/01/17, 09:33

  5. Susi Moog commented on patch set 1 V -1 11/02/17, 21:12

    I'd rather have the extension not installed afterwards, as potential post install scripts might rely on the database tables being there. For me the extension could not be installed if there are sql errors. Additionally it would be nice to have the original error message (the one that is displayed if you set SQL debug to 1) displayed "somewhere" - either in the error message if possible, or at least with a hint on enabling sqldebug in the message. Because in comparison we now only say that there was an error "somewhere" in the query, while the debug output narrows down the offending part considerably SQL Debug message: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'alter int(11) UNSIGNED NOT NULL default '0', tstamp int(11) UNSIGNED NOT NULL de' at line 4 Current Flash message in comparison: Error: You have an error in your SQL syntax;CREATE TABLE tx_issue82245_domain_model_foo ( uid int(11) NOT NULL AUTO_INCREMENT, pid int(11) NOT NULL default '0', alter int(11) UNSIGNED NOT NULL default '0', tstamp int(11) UNSIGNED NOT NULL default '0', crdate int(11) UNSIGNED NOT NULL default '0', cruser_id int(11) UNSIGNED NOT NULL default '0', PRIMARY KEY (uid), KEY parent (pid) );
  6. Susi Moog commented on patch set 1 V 0 12/08/17, 12:50

    As discussed, removing my -1 here as there is no easy way to show a more beautiful message.
  7. Oliver Klee voted on patch set 1 CR +1 12/13/17, 13:29

  8. Sybille Peters voted on patch set 1 V +1 02/13/18, 22:14

  9. Sascha Rademacher voted on patch set 1 CR +1 02/19/18, 09:37

  10. Alexander Opitz rebased onto patch set 2 02/19/18, 11:06

  11. Alexander Opitz uploaded patch set 3 02/19/18, 11:07

  12. Alexander Opitz commented on patch set 3 V +1 CR +1 02/19/18, 11:08

    Added an @internal hint inside the exception, as it is only used in v7
  13. Andreas Kienast commented on patch set 3 02/19/18, 11:09

    InstallUtility.php:490

    I guess this should be a colon instead.
  14. TYPO3com commented on patch set 2 02/19/18, 11:13 Completed build in 07m 21s on Mon, 19 Feb, 12:13 PM Test Summary: 49124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1362

  15. Nicole Hummel commented on patch set 3 02/19/18, 11:14

    InstallUtility.php:490 Reply Unresolved

    I think it was intended and taken from the exception message
  16. TYPO3com voted on patch set 3 V +1 02/19/18, 11:18 Completed build in 10m 40s on Mon, 19 Feb, 12:18 PM Test Summary: 49124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1363

  17. Andreas Kienast commented on patch set 3 02/19/18, 18:13

    Well, "Error: You have an error in your SQL syntax;CREATE TABLE ..." looks strange to me. Another thing: There is an SQL error, but the extension itself still gets installed, is this intended?
  18. Benni Mack voted on patch set 3 CR +2 05/25/18, 11:14

  19. Benni Mack voted on patch set 3 V +2 05/25/18, 12:23

  20. Benni Mack merged patch set 4 05/25/18, 12:23