Review main Abandoned Breaking

54508[!!!][TASK] Disable no_cache parameter for new installations

Josef Glatz CR 0 V 0 Easy +26 −0 updated 11/28/17, 22:19

Commit message

The no_cache parameter is disabled by default
during installation process.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 810

  1. Josef Glatz uploaded patch set 1 10/30/17, 20:57

  2. TYPO3com voted on patch set 1 V -1 10/30/17, 21:06 Completed build in 08m 55s on Mon, 30 Oct, 10:06 PM Test Summary: 2 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15931

  3. Josef Glatz rebased onto patch set 2 10/31/17, 08:47

  4. TYPO3com voted on patch set 2 V +1 10/31/17, 08:57 Completed build in 09m 37s on Tue, 31 Oct, 09:57 AM Test Summary: 56936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15939

  5. Mathias Brodala commented on patch set 2 11/01/17, 08:18

    Important-82884-DisableNo_cacheParameterForNewInstallations.rst:4

    Either this should be "Breaking" instead or "[!!!]" should be removed. This is not really breaking however since existing installations won't have a change in behavior when upgrading.
  6. Christian Kuhn commented on patch set 2 11/01/17, 11:00

    i think the core itself uses &no_cache=1 in certain situations in frontend - either in normal previews or in workspace previews if i remember correctly. this needs to be checked. if the core uses it, this patch will be harder to get in since it would break core functionality.
  7. Mathias Brodala commented on patch set 2 CR -1 11/01/17, 11:10

    > i think the core itself uses &no_cache=1 in certain situations in > frontend - either in normal previews or in workspace previews if i > remember correctly. this needs to be checked. if the core uses it, > this patch will be harder to get in since it would break core > functionality. Absolutely correct, see https://review.typo3.org/50264
  8. Josef Glatz commented on patch set 2 11/02/17, 07:02

    So, after https://review.typo3.org/#/c/50264/ get's merged, this isn't a breaking change anymore?
  9. Mathias Brodala commented on patch set 2 11/02/17, 08:12

    > So, after https://review.typo3.org/#/c/50264/ get's merged, this > isn't a breaking change anymore? No, that change only improves the situation for Extbase plugins, you'll still have the no_cache parameter if no specific preview configuration was defined.
  10. Benni Mack abandoned the change 11/28/17, 22:19

    Id say we need to wait with this change until we really got rid of no cache parameters everywhere in the core. I'll abandon this patch for the time being.