Review main Merged Breaking

54523[!!!][TASK] Streamline ExtensionManagementUtility

Benni Mack CR +2 V +2 Hard +543 −226 updated 01/10/18, 17:31

Commit message

The following functionality within this API class is marked as deprecated:
- siteRelPath()
- getExtensionKeyByPrefix()
- removeCacheFiles()
- second parameter of isLoaded()

Additionally, the following more strict rules apply now:
- addNavigationComponent() always requires an $extensionKey
- First parameter of addLLrefForTCAdescr() must not be empty
- addService() requires $serviceType and $info to be non-empty
- addPlugin() always requires an $extensionKey
- addStaticFile() throws exceptions if no extension key or path is set
- addTypoScript() expects $type to be either "setup" or "constants"

This is meant for extension developers using the current API more properly
than before.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 812

  1. Benni Mack uploaded patch set 1 11/02/17, 05:55

  2. TYPO3com voted on patch set 1 V -1 11/02/17, 06:04 Completed build in 09m 20s on Thu, 2 Nov, 07:04 AM Test Summary: 50 of 57289 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15970

  3. Benni Mack uploaded patch set 2 11/02/17, 11:17

  4. TYPO3com voted on patch set 2 V -1 11/02/17, 11:18 Completed build in 11s on Thu, 2 Nov, 12:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15986

  5. Benni Mack uploaded patch set 3 11/02/17, 11:23

  6. TYPO3com voted on patch set 3 V +1 11/02/17, 11:34 Completed build in 10m 54s on Thu, 2 Nov, 12:34 PM Test Summary: 56894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15987

  7. Benni Mack uploaded patch set 4 11/02/17, 14:58

  8. TYPO3com voted on patch set 4 V +1 11/02/17, 15:07 Completed build in 09m 14s on Thu, 2 Nov, 04:07 PM Test Summary: 56894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15993

  9. Mathias Schreiber voted on patch set 4 CR +1 V +1 11/02/17, 15:13

  10. Susi Moog voted on patch set 4 CR +2 V +2 11/02/17, 15:43

  11. Gerrit merged patch set 4 11/02/17, 15:43

  12. Nicole Hummel commented on patch set 5 01/10/18, 17:31

    ExtensionManagementUtility.php:978

    Wrong exception message. The first parameter needs to be set, not the third one. Will push a patch asap.