Review main Abandoned

54537[WIP][FEATURE] Add API call to add Content Element Types

Benni Mack CR 0 V 0 Normal +107 −0 updated 12/09/17, 22:04

Commit message

This is a first attempt to find a good "core-way" to create content elements.

A custom API to add a select Item for CType, a own type with a field list,
separated with tabs as arrays

Still open:
- Registration of New Content Element Wizard
- Registration of Default Template (via TypoScript)

This is a compilation together with Benjamin Kott, up for discussion.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 46

  1. Benni Mack uploaded patch set 1 11/02/17, 18:51

  2. TYPO3com voted on patch set 1 V -1 11/02/17, 18:51 Completed build in 08s on Thu, 2 Nov, 07:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16010

  3. Benni Mack uploaded patch set 2 11/02/17, 18:52

  4. TYPO3com voted on patch set 2 V +1 11/02/17, 19:02 Completed build in 09m 25s on Thu, 2 Nov, 08:02 PM Test Summary: 56894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16011

  5. Frans Saris commented on patch set 2 11/03/17, 12:51

    isn't this also the perfect time to create a own class for this functionality instead of making ExtensionManagementUtility bigger.

    ExtensionManagementUtility.php:581

    Maybe only add body text here when it's part of $fieldLists?
  6. Benni Mack abandoned the change 12/09/17, 22:04

    won't do it like that. nice idea but let's wait