Review main Merged Breaking

54540[!!!][TASK] Remove sys_domain.forced database field

Benni Mack CR +2 V +2 Normal +96 −95 updated 11/08/17, 09:34

Commit message

The DB setting "sys_domain.forced" is confusing and does not make sense
nowadays, especially with nested domain records - where the rootline is now
correctly traversed with the RootLine utility.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Gorges +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1825

  1. Benni Mack uploaded patch set 1 11/03/17, 10:44

  2. TYPO3com voted on patch set 1 V -1 11/03/17, 10:53 Completed build in 09m 22s on Fri, 3 Nov, 11:53 AM Test Summary: 31 of 57253 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16026

  3. Benni Mack uploaded patch set 2 11/03/17, 17:08

  4. TYPO3com voted on patch set 2 V -1 11/03/17, 17:17 Completed build in 09m 12s on Fri, 3 Nov, 06:17 PM Test Summary: 23 of 57049 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16050

  5. Benni Mack uploaded patch set 3 11/05/17, 15:08

  6. TYPO3com voted on patch set 3 V -1 11/05/17, 15:16 Completed build in 08m 32s on Sun, 5 Nov, 04:16 PM Test Summary: 4 of 57103 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16090

  7. Benni Mack uploaded patch set 4 11/05/17, 15:40

  8. TYPO3com voted on patch set 4 V +1 11/05/17, 15:49 Completed build in 09m 18s on Sun, 5 Nov, 04:49 PM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16092

  9. Benni Mack uploaded patch set 5 11/05/17, 16:45

  10. TYPO3com voted on patch set 5 V +1 11/05/17, 16:55 Completed build in 09m 50s on Sun, 5 Nov, 05:55 PM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16095

  11. Andreas Wolf commented on patch set 5 11/05/17, 17:48

    Breaking-82926-RemovedDatabaseFieldSysDomainForcedFlag.rst:13

    partially = for some use cases, or was it broken for all use cases, but only in some scenarios? The description is a bit vague here, but that’s probably ok if this feature was not used a lot.

    TypoScriptFrontendController.php:4348

    shouldn’t "isset()" be "… > 0" instead?
  12. Tymoteusz Motylewski commented on patch set 5 CR -1 11/05/17, 19:02

    Breaking-82926-RemovedDatabaseFieldSysDomainForcedFlag.rst:12

    please also state the label of the filed, somewhere here, so it's easier to understand what the field was about "Always prepend this domain in links:"
  13. Stefan Neufeind commented on patch set 5 11/06/17, 06:07

    TypoScriptFrontendController.php:4348 Reply

    Otherwise it wouldn't have pid set at all, I guess. But you might be right that !empty() or maybe >0 might be clearer here, since we don't have domain-records on the root-page (pid=0). We don't do versioning for domain-records, do we? Otherwise >0 wouldn't work here.
  14. Stefan Neufeind commented on patch set 5 11/06/17, 06:09

    @Benni: Besides small things here in general a big thanks for this patch!
  15. Benni Mack commented on patch set 5 11/07/17, 07:35

    TypoScriptFrontendController.php:4348 Reply

    please review the code before and after. It's the same, and it needs to be isset(). $sysDomainData is a consolidated array of one-domain-record per pid. so we check if the while() loop has already an entry in this $sysDomainData array. "> 0" does not work as the $sysDomainData is an array.
  16. Benni Mack uploaded patch set 6 11/08/17, 05:48

  17. TYPO3com voted on patch set 6 V +1 11/08/17, 05:58 Completed build in 10m 17s on Wed, 8 Nov, 06:58 AM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16168

  18. Daniel Gorges voted on patch set 6 CR +1 V +1 11/08/17, 06:52

  19. Stefan Neufeind commented on patch set 6 CR -1 V +1 11/08/17, 07:10

    Breaking-rst needs to be in the master-subdir. Will take care.
  20. Stefan Neufeind uploaded patch set 7 11/08/17, 07:12

  21. Stefan Neufeind voted on patch set 7 CR +1 V +1 11/08/17, 07:17

  22. TYPO3com voted on patch set 7 V +1 11/08/17, 07:22 Completed build in 09m 59s on Wed, 8 Nov, 08:22 AM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16172

  23. Daniel Gorges voted on patch set 7 CR +1 V +1 11/08/17, 07:55

  24. Stefan Neufeind voted on patch set 7 CR +2 V +2 11/08/17, 09:34

  25. Gerrit merged patch set 7 11/08/17, 09:34