54540[!!!][TASK] Remove sys_domain.forced database field
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Gorges +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Gorges +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Tests/Functional/Utility/Fixtures/sys_domain.xml+0 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82926-RemovedDatabaseFieldSysDomainForcedFlag.rstnew+44 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-82926-DomainRelatedApiMethodInTSFE.rstnew+33 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+8 −15
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −1
- typo3/sysext/frontend/Configuration/TCA/sys_domain.php+1 −9
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −3
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+0 −62
- typo3/sysext/frontend/Tests/Functional/Tca/DomainVisibleFieldsTest.php+1 −2
- typo3/sysext/frontend/ext_tables.sql+0 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1825
-
Benni Mack uploaded patch set 1 11/03/17, 10:44
-
TYPO3com voted on patch set 1 V -1 11/03/17, 10:53 Completed build in 09m 22s on Fri, 3 Nov, 11:53 AM Test Summary: 31 of 57253 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16026
-
Benni Mack uploaded patch set 2 11/03/17, 17:08
-
TYPO3com voted on patch set 2 V -1 11/03/17, 17:17 Completed build in 09m 12s on Fri, 3 Nov, 06:17 PM Test Summary: 23 of 57049 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16050
-
Benni Mack uploaded patch set 3 11/05/17, 15:08
-
TYPO3com voted on patch set 3 V -1 11/05/17, 15:16 Completed build in 08m 32s on Sun, 5 Nov, 04:16 PM Test Summary: 4 of 57103 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16090
-
Benni Mack uploaded patch set 4 11/05/17, 15:40
-
TYPO3com voted on patch set 4 V +1 11/05/17, 15:49 Completed build in 09m 18s on Sun, 5 Nov, 04:49 PM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16092
-
Benni Mack uploaded patch set 5 11/05/17, 16:45
-
TYPO3com voted on patch set 5 V +1 11/05/17, 16:55 Completed build in 09m 50s on Sun, 5 Nov, 05:55 PM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16095
-
Andreas Wolf commented on patch set 5 11/05/17, 17:48
TypoScriptFrontendController.php:4348shouldn’t "isset()" be "… > 0" instead? -
Tymoteusz Motylewski commented on patch set 5 CR -1 11/05/17, 19:02
Breaking-82926-RemovedDatabaseFieldSysDomainForcedFlag.rst:12please also state the label of the filed, somewhere here, so it's easier to understand what the field was about "Always prepend this domain in links:" -
Stefan Neufeind commented on patch set 5 11/06/17, 06:07
TypoScriptFrontendController.php:4348ReplyOtherwise it wouldn't have pid set at all, I guess. But you might be right that !empty() or maybe >0 might be clearer here, since we don't have domain-records on the root-page (pid=0). We don't do versioning for domain-records, do we? Otherwise >0 wouldn't work here. -
Stefan Neufeind commented on patch set 5 11/06/17, 06:09
@Benni: Besides small things here in general a big thanks for this patch! -
Benni Mack commented on patch set 5 11/07/17, 07:35
TypoScriptFrontendController.php:4348Replyplease review the code before and after. It's the same, and it needs to be isset(). $sysDomainData is a consolidated array of one-domain-record per pid. so we check if the while() loop has already an entry in this $sysDomainData array. "> 0" does not work as the $sysDomainData is an array. -
Benni Mack uploaded patch set 6 11/08/17, 05:48
-
TYPO3com voted on patch set 6 V +1 11/08/17, 05:58 Completed build in 10m 17s on Wed, 8 Nov, 06:58 AM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16168
-
Daniel Gorges voted on patch set 6 CR +1 V +1 11/08/17, 06:52
-
Stefan Neufeind commented on patch set 6 CR -1 V +1 11/08/17, 07:10
Breaking-rst needs to be in the master-subdir. Will take care. -
Stefan Neufeind uploaded patch set 7 11/08/17, 07:12
-
Stefan Neufeind voted on patch set 7 CR +1 V +1 11/08/17, 07:17
-
TYPO3com voted on patch set 7 V +1 11/08/17, 07:22 Completed build in 09m 59s on Wed, 8 Nov, 08:22 AM Test Summary: 56744 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16172
-
Daniel Gorges voted on patch set 7 CR +1 V +1 11/08/17, 07:55
-
Stefan Neufeind voted on patch set 7 CR +2 V +2 11/08/17, 09:34
-
Gerrit merged patch set 7 11/08/17, 09:34
Breaking-82926-RemovedDatabaseFieldSysDomainForcedFlag.rst:13