Review main Merged

54559[BUGFIX] Hint for 'Check for broken extensions' if install tool crashes

Susi Moog CR +2 V +2 Easy +6 −2 updated 11/28/17, 19:50

Commit message

If the install tool crashes in cards that load ext_* files from extensions,
it currently clears html body and only renders a message "Something went wrong".

This will later become a recovery view which can analyze where and how the
error happened to show the user good option on how to resurrect the instance.

For now, the message is extended a bit linking to the "Upgrade" menu saying
one should use the "Check for broken extensions". This way - until a bigger
solution evolved - we at least have a link to click on, and the user does not
need to fiddle with the url bar of the browser. This is especially useful
in install tool standalone mode where the whole content including the left
main menu is currently substituted by the error message.

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Susi Moog uploaded patch set 1 11/05/17, 11:44

  2. Susi Moog updated the commit message in patch set 2 11/05/17, 11:47

  3. TYPO3com voted on patch set 1 V +1 11/05/17, 11:56 Completed build in 11m 42s on Sun, 5 Nov, 12:56 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16086

  4. TYPO3com voted on patch set 2 V +1 11/05/17, 11:57 Completed build in 09m 39s on Sun, 5 Nov, 12:57 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16087

  5. Susi Moog commented on patch set 3 11/06/17, 07:23

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 11/06/17, 07:33 Completed build in 09m 59s on Mon, 6 Nov, 08:33 AM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16099

  7. Christian Kuhn commented on patch set 3 CR -1 11/06/17, 09:15

    -1 - the idea was here to call the router and let it perform a recovery that goes through a series of single checks to better locate the issue. it is not only ext_* that could go wrong. the handleError() is currently a stub with its simple error message and should be extended accordingly.
  8. Susi Moog commented on patch set 3 11/06/17, 09:27

    The router is the top level error handler, which is fine. But it does not know the current container that produced the error and is not able to display that error message in a sensible place. In case of broken extensions we should at least try to give the user a sensible hint - and let him continue to use the tool. If you have an idea on how to achieve the same with the top level router, feel free to add it because I did not manage to do so, but the situation at the moment is pretty much unusable and should be fixed soon.
  9. Christian Kuhn commented on patch set 3 11/09/17, 21:23

    alright. i see your point. let us have a look at this the other day. ping me if you want to catch up on that, otherwise i'll pick it up later.
  10. Benni Mack commented on patch set 3 11/28/17, 12:27

    ping
  11. Christian Kuhn uploaded patch set 4 11/28/17, 18:00

  12. TYPO3com voted on patch set 4 V +1 11/28/17, 18:10 Completed build in 10m 17s on Tue, 28 Nov, 07:10 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16848

  13. Susi Moog voted on patch set 4 CR +1 11/28/17, 19:15

  14. Benni Mack voted on patch set 4 CR +2 V +1 11/28/17, 19:48

  15. Susi Moog voted on patch set 4 V +2 11/28/17, 19:50

  16. Gerrit merged patch set 4 11/28/17, 19:50