Review main Merged Breaking

54560[!!!][TASK] Remove hardly used pagetree related TS options

Benni Mack CR +2 V +2 Normal +39 −45 updated 11/06/17, 10:18

Commit message

The following pageTSconfig options are removed:

- options.pageTree.excludeDoktypes
No doktypes are exclueded anymore in search.

- options.pageTree.disableIconLinkToContextmenu
Icon Links are always selected (option had no effect anymore).

- options.pageTree.searchInAlias
Alias is now always searched for.

- options.pageTree.hideFilter
The filter is always shown, this feature should not be available
on a per-user basis.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Eugene Kenah Djomo +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 911

  1. Benni Mack uploaded patch set 1 11/05/17, 15:38

  2. TYPO3com voted on patch set 1 V +1 11/05/17, 15:49 Completed build in 10m 25s on Sun, 5 Nov, 04:49 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16091

  3. Benni Mack uploaded patch set 2 11/05/17, 16:27

  4. Wouter Wolters voted on patch set 2 CR +1 11/05/17, 16:31

  5. TYPO3com voted on patch set 2 V +1 11/05/17, 16:36 Completed build in 08m 36s on Sun, 5 Nov, 05:36 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16094

  6. Wouter Wolters voted on patch set 2 V +1 11/05/17, 18:38

  7. Jörg Bösche voted on patch set 2 CR +1 11/06/17, 08:45

  8. Eugene Kenah Djomo commented on patch set 2 CR +1 11/06/17, 09:47

    Looks good
  9. Georg Ringer voted on patch set 2 CR +1 V +1 11/06/17, 10:17

  10. Georg Ringer voted on patch set 2 CR +2 V +2 11/06/17, 10:18

  11. Gerrit merged patch set 2 11/06/17, 10:18