Review TYPO3_8-7 Merged

54566[TASK] Refactor implementation of PaginateWidget

Jigal van Hemert CR +2 V +2 Normal +60 −62 updated 11/06/17, 10:38

Commit message

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 6

Review log 34

  1. Jigal van Hemert commented on patch set 1 11/06/17, 10:24

    Cherry Picked from branch master.
  2. Jigal van Hemert commented on patch set 1 CR +2 V +2 11/06/17, 10:28

    No changes in code in this area between branches. Everything worked fine as expected.
  3. Gerrit merged patch set 1 11/06/17, 10:28

  4. TYPO3com commented on patch set 1 11/06/17, 10:38 Completed build in 13m 53s on Mon, 6 Nov, 11:38 AM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1160