Review main Merged

54572[TASK] Apply JS CGL on SvgTree files

Tymoteusz Motylewski CR +2 V +2 Expert +959 −922 updated 11/07/17, 13:29

Commit message

In order to make page tree smaller and easier to review,
this patch applies new JS CGLs on SvgTree related files.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 910

  1. Tymoteusz Motylewski uploaded patch set 1 11/06/17, 22:00

  2. TYPO3com voted on patch set 1 V +1 11/06/17, 22:10 Completed build in 09m 52s on Mon, 6 Nov, 11:10 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16137

  3. Markus Klein commented on patch set 1 11/06/17, 22:41

    SvgTree.js:34

    is this allowed for JS syntax to have a trailing comma after the last element in an object? At least up to now I thought it is forbidden (and phpstorm colors that red)
  4. Tymoteusz Motylewski commented on patch set 1 11/06/17, 23:03

    SvgTree.js:34 Reply

    trailing comma can cause issue with IE6/7 and IE9 if it's in quirksmode. AFAIK we require gte IE10. Since ES5 it's also part of the standard.
  5. Wouter Wolters voted on patch set 1 CR +1 11/07/17, 07:07

  6. Markus Klein commented on patch set 1 CR +1 V +1 11/07/17, 09:53

    Good to know, thanks
  7. Tymoteusz Motylewski commented on patch set 1 CR -2 11/07/17, 11:30

    need to double check some details
  8. Tymoteusz Motylewski commented on patch set 1 CR 0 11/07/17, 12:11

    all good
  9. Christian Kuhn voted on patch set 1 CR +2 V +2 11/07/17, 13:29

  10. Gerrit merged patch set 1 11/07/17, 13:29