54572[TASK] Apply JS CGL on SvgTree files
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js+128 −123
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+53 −50
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SvgTree.js2+639 −622
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TreeToolbar.js+139 −127
Review log 910
-
Tymoteusz Motylewski uploaded patch set 1 11/06/17, 22:00
-
TYPO3com voted on patch set 1 V +1 11/06/17, 22:10 Completed build in 09m 52s on Mon, 6 Nov, 11:10 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16137
-
Markus Klein commented on patch set 1 11/06/17, 22:41
-
Tymoteusz Motylewski commented on patch set 1 11/06/17, 23:03
SvgTree.js:34Replytrailing comma can cause issue with IE6/7 and IE9 if it's in quirksmode. AFAIK we require gte IE10. Since ES5 it's also part of the standard. -
Wouter Wolters voted on patch set 1 CR +1 11/07/17, 07:07
-
Markus Klein commented on patch set 1 CR +1 V +1 11/07/17, 09:53
Good to know, thanks -
Tymoteusz Motylewski commented on patch set 1 CR -2 11/07/17, 11:30
need to double check some details -
Tymoteusz Motylewski commented on patch set 1 CR 0 11/07/17, 12:11
all good -
Christian Kuhn voted on patch set 1 CR +2 V +2 11/07/17, 13:29
-
Gerrit merged patch set 1 11/07/17, 13:29
SvgTree.js:34