Review main Merged

54575[BUGFIX] Add label to page ID field in PageLinkHandler

Georg Ringer CR +2 V +2 Easy +13 −10 updated 11/14/17, 07:07

Commit message

Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Jan Stockfisch +1
    • Andreas Kienast +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Georg Ringer uploaded patch set 1 11/07/17, 07:12

  2. TYPO3com voted on patch set 1 V +1 11/07/17, 07:22 Completed build in 09m 09s on Tue, 7 Nov, 08:22 AM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16143

  3. Wouter Wolters voted on patch set 1 CR +1 11/07/17, 07:28

  4. Markus Klein voted on patch set 1 CR +1 V +1 11/07/17, 09:22

  5. Frank Nägler commented on patch set 1 11/09/17, 12:49

    PageLinkHandler.php:282

    are you sure about adding a form tag here? I guess there will be another form tag in the final rendering, so this could end in a form within a form?
  6. Markus Klein commented on patch set 1 11/09/17, 17:37

    PageLinkHandler.php:282 Reply

    Yes that's indeed a nested form, but this is how it has to be! Each field here has its own form. Even tough the form is actually useless for functionality, since the dumb JS works with click-event and id reference
  7. Oliver Klee commented on patch set 2 11/09/17, 18:25

    Published edit on patch set 1.
  8. Oliver Klee updated the commit message in patch set 3 11/09/17, 18:25

  9. Markus Klein voted on patch set 3 CR +1 V +1 11/09/17, 18:31

  10. TYPO3com voted on patch set 2 V -1 11/09/17, 18:37 Completed build in 12m 18s on Thu, 9 Nov, 07:37 PM Test Summary: 1 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16223

  11. TYPO3com voted on patch set 3 V +1 11/09/17, 18:38 Completed build in 13m 11s on Thu, 9 Nov, 07:38 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16224

  12. Jan Stockfisch voted on patch set 3 CR +1 11/13/17, 09:51

  13. Markus Klein commented on patch set 3 11/13/17, 10:40

    Required ckeditor config is available in the ticket
  14. Henning Liebe voted on patch set 3 V +1 11/13/17, 11:15

  15. Andreas Kienast commented on patch set 3 11/13/17, 11:52

    PageLinkHandler.php:282

    Is it correct to have a completely new form here?
  16. Andreas Kienast commented on patch set 3 CR +1 11/13/17, 12:50

    Gna, never mind my comment
  17. Stefan Neufeind voted on patch set 3 CR +2 V +2 11/14/17, 07:06

  18. Gerrit merged patch set 3 11/14/17, 07:07

  19. Stefan Neufeind commented on patch set 4 11/14/17, 07:07

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 76e6697a6867a1f82df21e88d702525b01fe00a9