Review TYPO3_8-7 Merged

54581[TASK] Add Fluid expressions and pre-processors global config

Jigal van Hemert CR +2 V +2 Normal +52 −10 updated 11/09/17, 12:15

Commit message

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Jigal van Hemert +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1315

  1. Jigal van Hemert uploaded patch set 1 11/07/17, 14:24

  2. TYPO3com voted on patch set 1 V +1 11/07/17, 14:35 Completed build in 11m 20s on Tue, 7 Nov, 03:35 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1173

  3. Stefan Neufeind commented on patch set 1 11/08/17, 10:57

    I deem it low-critical for 8.7 and we could have it. It might ease using that functionality with existing installations. But do we consider it "important enough" to break with the rule not to introduce new things during an LTS-lifecycle?
  4. Stefan Neufeind commented on patch set 1 11/08/17, 10:58

    Important-82763-GlobalFluidExpressionNodeTypeAndTemplatePreProcessorConfiguration.rst

    Changelog would need to be placed in 8.7-directory then
  5. Claus Due commented on patch set 1 11/08/17, 11:18

    > I deem it low-critical for 8.7 and we could have it. It might ease using that functionality with existing installations. But do we consider it "important enough" to break with the rule not to introduce new things during an LTS-lifecycle? As mentioned elsewhere, this is a pre-requisite for improving the Fluid integration in the frontend_editing extension in several ways, without requiring each extension to opt-in to such capabilities. See https://gist.github.com/NamelessCoder/9aca683920d9e4225f0527e0ce900ba8 It is highly critical at least for this one extension - and definitely useful for others as well, who do such overrides but prefer to keep them in static configuration.
  6. Stefan Neufeind commented on patch set 1 CR +1 11/08/17, 11:30

    Thanks for the details. Okay, I'm in we might consider it for 8.7 as well. Let's see how Benni feels about it.
  7. Jigal van Hemert commented on patch set 1 11/08/17, 11:42

    > Thanks for the details. Okay, I'm in we might consider it for 8.7 > as well. Let's see how Benni feels about it. Benni already approved backporting this change. There were no changes in this code between branches, but I just wanted to make sure others didn't find issues and offered it for review.
  8. Benni Mack voted on patch set 1 CR +2 11/08/17, 20:03

  9. Benni Mack commented on patch set 2 11/08/17, 20:04

    Published edit on patch set 1.
  10. Benni Mack voted on patch set 2 CR +1 11/08/17, 20:05

  11. TYPO3com voted on patch set 2 V +1 11/08/17, 20:18 Completed build in 13m 15s on Wed, 8 Nov, 09:18 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1184

  12. Wouter Wolters voted on patch set 2 CR +1 11/08/17, 20:18

  13. Stefan Neufeind voted on patch set 2 CR +1 11/08/17, 23:26

  14. Jigal van Hemert commented on patch set 2 CR +2 V +2 11/09/17, 12:15

    Straight backport (only the rst was moved), no code changed in this area between branches. Merging now because it's needed for FE edit.
  15. Gerrit merged patch set 2 11/09/17, 12:15