54586[BUGFIX] Properly encode text in JS in install tool
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/install/Resources/Public/JavaScript/Modules/CoreUpdate.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Modules/DatabaseAnalyzer.js+3 −3
- typo3/sysext/install/Resources/Public/JavaScript/Modules/ExtensionScanner.js+4 −4
- typo3/sysext/install/Resources/Public/JavaScript/Modules/FlashMessage.js+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/Modules/InfoBox.js+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/Modules/ProgressBar.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Modules/UpgradeWizards.js2+2 −2
Review log 2124
-
Georg Ringer uploaded patch set 1 11/08/17, 11:51
-
Mathias Brodala commented on patch set 1 11/08/17, 11:54
-
Helmut Hummel commented on patch set 1 CR -1 11/08/17, 12:00
I would really like to have the title of the row updaters to properly encoded when rendered. this would make this api more useful in other contexts than html as well (hello typo3 console) :)RteLinkSyntaxUpdater.php:76Replyhow about defining this as clear text and properly encoding it in the place where this is rendered? -
Markus Klein voted on patch set 1 CR +1 V +1 11/08/17, 12:00
-
TYPO3com voted on patch set 1 V +1 11/08/17, 12:00 Completed build in 08m 48s on Wed, 8 Nov, 01:00 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16182
-
Markus Klein commented on patch set 1 CR -1 11/08/17, 12:01
fair enough I agree with Helmut in that case -
Georg Ringer commented on patch set 1 11/08/17, 12:18
this means then that it is not possible to use html in the title if is is escaped everywhere -
Helmut Hummel commented on patch set 1 11/08/17, 12:21
> this means then that it is not possible to use html in the title if is is escaped everywhere yes, this is exactly what this means :) If you think about usage in contexts outside of html, then you can't put html in there. end of story :) -
Helmut Hummel commented on patch set 1 11/08/17, 12:23
funny side story: in one place it is htmlspecialchar'ed, on the other usage it is not -
Helmut Hummel commented on patch set 1 11/08/17, 12:24
which means, this change breaks one usage and the other usage should be fixed instead -
Helmut Hummel commented on patch set 1 11/08/17, 12:25
uhm, one place htmlspecialchars other place correct fluid usage. from reading the code, everyting should be fine, strange -
Helmut Hummel commented on patch set 1 11/08/17, 12:32
ah, js foo in master :-/ -
Helmut Hummel uploaded patch set 2 11/08/17, 12:39
-
Helmut Hummel commented on patch set 2 CR +1 V +1 11/08/17, 12:41
UpgradeWizards.js:413here .text() is already usedUpgradeWizards.js:422here, for some reason .html() was used -
Wouter Wolters voted on patch set 2 CR +1 11/08/17, 12:41
-
TYPO3com voted on patch set 2 V +1 11/08/17, 12:47 Completed build in 08m 28s on Wed, 8 Nov, 01:47 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16184
-
Mathias Brodala voted on patch set 2 CR +1 11/08/17, 13:26
-
Susi Moog uploaded patch set 3 11/08/17, 14:31
-
TYPO3com voted on patch set 3 V +1 11/08/17, 14:41 Completed build in 09m 38s on Wed, 8 Nov, 03:41 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16192
-
Markus Klein voted on patch set 3 CR +1 11/08/17, 15:58
-
Stefan Neufeind commented on patch set 3 CR +1 V +1 11/08/17, 16:20
looks fine so far during testing -
Michael Oehlhof voted on patch set 3 CR +1 11/08/17, 16:27
-
Markus Klein voted on patch set 3 CR +2 V +2 11/08/17, 21:20
-
Gerrit merged patch set 3 11/08/17, 21:20
RteLinkSyntaxUpdater.php:76