Review main Abandoned

54597[RESEARCH] Move cache_treelist to caching framework

Benni Mack CR 0 V 0 Normal +33 −150 updated 11/29/17, 14:37

Commit message

There are things that are not possible with cache_treelist
anymore.

Cache_treelist creates an entry without expiration in FE,
then, once you update a record in BE, the expiration is set.

This is all weird...

Review

  • Code review CR 0
  • Verified V 0

Files 6

Review log 34

  1. Benni Mack uploaded patch set 1 11/08/17, 19:00

  2. TYPO3com voted on patch set 1 V +1 11/08/17, 19:11 Completed build in 10m 03s on Wed, 8 Nov, 08:11 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16200

  3. Susi Moog commented on patch set 1 11/15/17, 16:42

    If I get it right, what the expiration is supposed to do here is ensure that a page tree cache entry expires as soon as one of the pages in it expires. For example take the following scenario: - Page 1 -- Page 1.1 - Page 2 without start/end dates expiration times do not play into it, but: imagine Page 1.1 having a start date of day after tomorrow - so it will not be in the current frontend page tree if I get it right, but it should be day after tomorrow - so expiration has to be set for that day. Same goes if some page has a stop date set. Expiration for the tree cache has to take start/stop times into account, which we currently break, don't we?
  4. Benni Mack abandoned the change 11/29/17, 14:37