54598[BUGFIX] Set correct PID for file references on new pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Steffen Frese +1
- Sascha Rademacher +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Steffen Frese +1
- Sascha Rademacher +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php2+10 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+14 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php1+14 −6
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php1+8 −4
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+1 −1
Review log 5370
Show 3445 earlier messages
-
Michiel Roos uploaded patch set 1 11/08/17, 20:22
-
TYPO3com voted on patch set 1 V +1 11/08/17, 20:31 Completed build in 09m 00s on Wed, 8 Nov, 09:31 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16202
-
Markus Klein commented on patch set 1 CR -1 11/10/17, 08:31
The whole commit message is unfortunately not a commit message but a bug description. This should be in the issue ticket on forge and not here. Please adjust this message to describe what is changed. Thanks a lot. -
Markus Klein commented on patch set 1 11/10/17, 08:33
TcaInline.php:99this tells a different story, from what you changed things to below -
Markus Klein commented on patch set 1 11/10/17, 08:35
EditDocumentController.php:1047This member is described as "Is set to the pid value of the last shown record - thus indicating which page to show when clicking the SAVE/VIEW button". IMO this change will break the behaviour as it will show the parent page instead of the newly created page -
Michiel Roos uploaded patch set 2 11/10/17, 11:09
-
TYPO3com voted on patch set 2 V -1 11/10/17, 11:09 Completed build in 10s on Fri, 10 Nov, 12:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16233
-
Michiel Roos uploaded patch set 3 11/10/17, 11:13
-
Michiel Roos commented on patch set 3 11/10/17, 11:14
Reply
DoneEditDocumentController.php:1047ReplyIn your opinion only? Or in your actual test? The description may be off. Some parts of this code are ancient while the Form handling has seen a lot of change. -
TYPO3com voted on patch set 3 V -1 11/10/17, 11:22 Completed build in 09m 28s on Fri, 10 Nov, 12:22 PM Test Summary: 9 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16234
-
Michiel Roos uploaded patch set 4 11/10/17, 12:13
-
TYPO3com voted on patch set 4 V +1 11/10/17, 12:24 Completed build in 10m 23s on Fri, 10 Nov, 01:24 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16237
-
Markus Klein commented on patch set 1 11/10/17, 14:23
EditDocumentController.php:1047ReplyThis is true of course, but as you say, this is pretty old code. Changing anything here seems rather dangerous to me without really deep understanding of the bits and pieces. I once modified stuff around the preview things, which uses some of these members as well. I can try to take such a deep look, but that will take a while. -
Markus Klein updated the commit message in patch set 5 11/10/17, 14:24
-
TYPO3com voted on patch set 5 V +1 11/10/17, 14:35 Completed build in 10m 47s on Fri, 10 Nov, 03:35 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16244
-
Tomas Norre Mikkelsen voted on patch set 5 CR +1 11/30/17, 10:40
-
Sebastian Hofer uploaded patch set 6 11/30/17, 12:39
-
Tomas Norre Mikkelsen voted on patch set 6 CR +1 11/30/17, 12:41
-
Wouter Wolters commented on patch set 6 11/30/17, 12:41
FormInlineAjaxController.php:73use strpos($parent['uid'], 'NEW') === 0 insteadFormInlineAjaxController.php:131use strpos($parent['uid'], 'NEW') === 0 insteadFormDataCompiler.php:85use strpos($parent['uid'], 'NEW') !== 0 instead -
Wouter Wolters commented on patch set 6 11/30/17, 12:42
Substr invokes additional memory allocation, which is not needed in the context. Strpos will do the same job, but without any overhead (it's just searching a string). -
TYPO3com voted on patch set 6 V +1 11/30/17, 12:50 Completed build in 11m 34s on Thu, 30 Nov, 01:50 PM Test Summary: 57040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17101
-
Sebastian Hofer commented on patch set 6 CR -1 V -1 11/30/17, 13:34
This patch does not work on master. The pid in sys_file_reference is still '0'. -
Mathias Brodala commented on patch set 6 03/09/18, 13:59
Michiel, can you have another look at this? -
Wolfgang Klinger uploaded patch set 7 03/09/18, 18:19
-
Wolfgang Klinger commented on patch set 7 03/09/18, 18:25
I fixed the patch and reverted the change for $this->viewId (from uid to pid) in EditDocumentController, as it makes no difference for the preview -
TYPO3com voted on patch set 7 V +1 03/09/18, 18:27 Completed build in 08m 12s on Fri, 9 Mar, 07:27 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20763
-
Markus Klein voted on patch set 7 CR +1 03/09/18, 21:34
-
Jörg Bösche uploaded patch set 8 03/12/18, 09:16
-
TYPO3com voted on patch set 8 V +1 03/12/18, 09:26 Completed build in 09m 48s on Mon, 12 Mar, 10:26 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20821
-
Markus Klein voted on patch set 8 CR +1 03/12/18, 09:52
-
Frank Nägler commented on patch set 8 V +1 CR -1 03/16/18, 10:50
can confirm it works, but I am not sure about the solution. I have asked Lolli to have a look. If he think the change is ok, I will change my voting. -
Andreas Wolf commented on patch set 8 V +2 CR +1 03/16/18, 10:58
Giving my preliminary +1 for testing and code review, depending on the feedback by Frank/Lolli this is fine for merging IMO. -
Christian Kuhn commented on patch set 8 CR -1 03/16/18, 11:18
will review. -
Christian Kuhn commented on patch set 8 03/16/18, 12:07
andreas will have a second look on this. -
Andreas Wolf commented on patch set 8 CR -1 03/16/18, 12:37
After discussing this with Lolli, I revert my code review result—this should actually be fixed by making the inlineFirstPid also be "NEW…" instead of 0. -
Christian Kuhn uploaded patch set 9 03/16/18, 17:32
-
Christian Kuhn uploaded patch set 10 03/16/18, 17:38
-
Christian Kuhn commented on patch set 10 03/16/18, 17:40
pushed update. NO backport to v7 anymore, too risky. For v8: Have a merge in master first for a couple of weeks, then later merge to v8 after next release only. -
TYPO3com voted on patch set 9 V -1 03/16/18, 17:42 Completed build in 09m 52s on Fri, 16 Mar, 06:42 PM Test Summary: 23 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21304
-
Christian Kuhn commented on patch set 10 03/16/18, 17:45
still broken: exception in inline usecombination -
Christian Kuhn voted on patch set 10 CR -1 03/16/18, 17:45
-
TYPO3com voted on patch set 10 V -1 03/16/18, 17:49 Completed build in 10m 10s on Fri, 16 Mar, 06:49 PM Test Summary: 23 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21305
-
Christian Kuhn uploaded patch set 11 03/16/18, 17:52
-
TYPO3com voted on patch set 11 V -1 03/16/18, 18:00 Completed build in 08m 09s on Fri, 16 Mar, 07:00 PM Test Summary: 17 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21310
-
Christian Kuhn voted on patch set 11 CR -1 03/16/18, 18:44
-
Benni Mack commented on patch set 11 07/13/18, 11:47
ping, I do need this functionality in 7.6+, it's a serious bug, as editors cannot attach a media element to a new page, and then use it later-on -
Josef Glatz commented on patch set 11 10/09/18, 03:16
Is there any chance that is problem will be fixed in v9/v8? -
Mathias Brodala updated the commit message in patch set 12 10/09/18, 07:17
-
Mathias Brodala commented on patch set 12 10/09/18, 07:18
Micro change to trigger build. -
TYPO3com voted on patch set 12 V -1 10/09/18, 07:28 Completed build in 11m 15s on Tue, 9 Oct, 09:28 AM Test Summary: 16 of 38158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29365
-
Mathias Brodala commented on patch set 12 10/09/18, 07:46
OK, the tests really fail and need fixes first. -
Benni Mack updated the commit message in patch set 13 12/14/18, 09:58
-
Benni Mack commented on patch set 13 12/14/18, 09:58
Updated the releases line -
TYPO3com voted on patch set 13 V -1 12/14/18, 10:46 Completed build in 44m 09s on Fri, 14 Dec, 11:46 AM Test Summary: 17 of 49169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30690
-
Josef Glatz commented on patch set 13 CR -1 02/05/19, 12:44
8.7 needs also to be fixed! Even the issue itself refers to it. -
Josef Glatz updated the commit message in patch set 14 02/05/19, 12:50
-
TYPO3com voted on patch set 14 V -1 02/05/19, 13:04 Completed build in 14m 06s on Tue, 5 Feb, 02:04 PM Test Summary: 17 of 46806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32052
-
Wouter Wolters wrote 06/04/19, 13:16
Removed reviewer Wouter Wolters. -
Markus Klein rebased onto patch set 15 01/14/20, 17:56
-
TYPO3com voted on patch set 15 V -1 01/14/20, 18:03 Completed build in 07m 25s on Tue, 14 Jan, 06:03 PM Test Summary: 21 of 59626 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39929
-
Markus Klein uploaded patch set 16 01/14/20, 20:49
-
Markus Klein uploaded patch set 17 01/14/20, 20:58
-
TYPO3com voted on patch set 16 V -1 01/14/20, 21:00 Completed build in 11m 13s on Tue, 14 Jan, 09:00 PM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39942
-
Markus Klein voted on patch set 17 V +1 CR +1 01/14/20, 21:00
-
TYPO3com voted on patch set 17 V +1 01/14/20, 21:26 Completed build in 15m 38s on Tue, 14 Jan, 09:26 PM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39943
-
Steffen Frese voted on patch set 17 V +1 CR +1 01/17/20, 08:46
-
Sascha Rademacher voted on patch set 17 V +1 CR +1 01/17/20, 09:24
-
Benni Mack voted on patch set 17 V +2 CR +2 02/15/20, 07:50
-
Benni Mack merged patch set 18 02/15/20, 07:50
-
Benni Mack commented on patch set 18 02/15/20, 07:53
please test the backport: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63222