Review main Merged

54600[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility

Mathias Brodala CR +2 V +2 Easy +14 −1 updated 11/14/17, 13:57

Commit message

Variadic arguments are optional but do not have a default value, thus
properly check this.

Also render the variadic operator ("...") in the output.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Alexander Schnitzler +1
  • Verified V +2
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Mathias Brodala uploaded patch set 1 11/09/17, 08:43

  2. TYPO3com voted on patch set 1 V +1 11/09/17, 08:52 Completed build in 09m 33s on Thu, 9 Nov, 09:52 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16207

  3. Wouter Wolters voted on patch set 1 CR +1 11/09/17, 09:01

  4. Henning Liebe voted on patch set 1 CR +1 11/13/17, 10:23

  5. Alexander Schnitzler commented on patch set 1 11/14/17, 11:40

    What exactly do I need to debug to verify this change?
  6. Mathias Brodala commented on patch set 1 CR -1 11/14/17, 12:04

    > What exactly do I need to debug to verify this change? See the ticket on Forge. I'll add a unit test.
  7. Mathias Brodala uploaded patch set 2 11/14/17, 12:26

  8. TYPO3com voted on patch set 2 V -1 11/14/17, 12:26 Completed build in 07s on Tue, 14 Nov, 01:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16324

  9. Mathias Brodala uploaded patch set 3 11/14/17, 12:28

  10. TYPO3com voted on patch set 3 V -1 11/14/17, 12:28 Completed build in 07s on Tue, 14 Nov, 01:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16325

  11. Mathias Brodala uploaded patch set 4 11/14/17, 12:33

  12. TYPO3com voted on patch set 4 V +1 11/14/17, 12:44 Completed build in 10m 25s on Tue, 14 Nov, 01:44 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16326

  13. Alexander Schnitzler voted on patch set 4 CR +1 V +1 11/14/17, 13:22

  14. Andreas Kienast voted on patch set 4 CR +2 V +2 11/14/17, 13:57

  15. Gerrit merged patch set 4 11/14/17, 13:57

  16. Andreas Kienast commented on patch set 5 11/14/17, 13:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4e718d4e197c7fe4aa53d099ed166bdac6e2661b