54604[WIP][TASK] Refactor DocCommentParser
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 5
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+20 −26
- typo3/sysext/extbase/Classes/Reflection/DocCommentParser.php1+136 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/DocCommentParserTest.php+20 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+2 −2
Review log 410
-
Alexander Schnitzler uploaded patch set 1 11/09/17, 17:01
-
TYPO3com voted on patch set 1 V -1 11/09/17, 17:12 Completed build in 11m 18s on Thu, 9 Nov, 06:12 PM Test Summary: 8 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16220
-
Alexander Schnitzler uploaded patch set 2 11/09/17, 17:12
-
TYPO3com voted on patch set 2 V -1 11/09/17, 17:22 Completed build in 09m 36s on Thu, 9 Nov, 06:22 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221
-
TYPO3com commented on patch set 2 11/09/17, 18:24 Completed build in 1h 21m 32s on Thu, 9 Nov, 07:24 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221
-
Alexander Schnitzler commented on patch set 2 V -1 11/09/17, 19:04
-
TYPO3com commented on patch set 2 11/09/17, 19:28 Completed build in 3h 36m 54s on Thu, 9 Nov, 08:28 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221
-
TYPO3com commented on patch set 2 11/09/17, 20:21 Completed build in 6h 46m 07s on Thu, 9 Nov, 09:21 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221
-
TYPO3com commented on patch set 2 11/10/17, 08:10 Completed build in 21h 43m 40s on Fri, 10 Nov, 09:10 AM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221
-
Alexander Schnitzler abandoned the change 05/17/18, 09:18
This approach is a no go because uncached requests do take seconds for the reflection. Maybe this can better be done with roave/better-reflection.
DocCommentParser.php:201