Review main Abandoned

54604[WIP][TASK] Refactor DocCommentParser

Alexander Schnitzler CR 0 V 0 Normal +179 −29 updated 05/17/18, 09:18

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 410

  1. Alexander Schnitzler uploaded patch set 1 11/09/17, 17:01

  2. TYPO3com voted on patch set 1 V -1 11/09/17, 17:12 Completed build in 11m 18s on Thu, 9 Nov, 06:12 PM Test Summary: 8 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16220

  3. Alexander Schnitzler uploaded patch set 2 11/09/17, 17:12

  4. TYPO3com voted on patch set 2 V -1 11/09/17, 17:22 Completed build in 09m 36s on Thu, 9 Nov, 06:22 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221

  5. TYPO3com commented on patch set 2 11/09/17, 18:24 Completed build in 1h 21m 32s on Thu, 9 Nov, 07:24 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221

  6. Alexander Schnitzler commented on patch set 2 V -1 11/09/17, 19:04

    DocCommentParser.php:201

    Unfortunately this reflection massively slows down every uncached request as all namespaces are analyzed, so that relative class names for @var annotations can be resolved. That's a no go. I did profile the install tool with xdebug with and without this patch. Without, the cachegrind file was 2MB, with it was over 70MB. That alone shows the massive increase of CPU cycles needed. So for now, this can only get a -1.
  7. TYPO3com commented on patch set 2 11/09/17, 19:28 Completed build in 3h 36m 54s on Thu, 9 Nov, 08:28 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221

  8. TYPO3com commented on patch set 2 11/09/17, 20:21 Completed build in 6h 46m 07s on Thu, 9 Nov, 09:21 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221

  9. TYPO3com commented on patch set 2 11/10/17, 08:10 Completed build in 21h 43m 40s on Fri, 10 Nov, 09:10 AM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16221

  10. Alexander Schnitzler abandoned the change 05/17/18, 09:18

    This approach is a no go because uncached requests do take seconds for the reflection. Maybe this can better be done with roave/better-reflection.