Review main Merged

54611[TASK] Re-add autolinking RTE feature in CKeditor

Benni Mack CR +2 V +2 Normal +131 −0 updated 11/29/17, 22:15

Commit message

A missing functionality is added, which happened when introducing CKeditor.

Automatically linking a URL when typing www.typo3.org should happen directly.

A specific plugin is used for that. Base concept was taken from
https://github.com/Gnodiah/ckeditor-autolink

Review

  • Code review CR +2
    • Susi Moog +2
    • Sebastian Hofer +1
  • Verified V +2
    • Susi Moog +2
    • Riccardo De Contardi +1
    • Sebastian Hofer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Benni Mack uploaded patch set 1 11/10/17, 09:46

  2. Benni Mack updated the commit message in patch set 2 11/10/17, 09:50

  3. TYPO3com voted on patch set 1 V +1 11/10/17, 09:56 Completed build in 10m 05s on Fri, 10 Nov, 10:56 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16228

  4. TYPO3com voted on patch set 2 V +1 11/10/17, 10:00 Completed build in 10m 03s on Fri, 10 Nov, 11:00 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16229

  5. Riccardo De Contardi commented on patch set 2 V +1 11/11/17, 21:49

    tested with both links that begin with "www." and "http"; tested with space and carriage return. The links will automatically have target="_blank" :)
  6. Benni Mack commented on patch set 3 11/29/17, 14:38

    Published edit on patch set 2.
  7. Benni Mack updated the commit message in patch set 4 11/29/17, 14:39

  8. TYPO3com voted on patch set 4 V +1 11/29/17, 14:49 Completed build in 10m 16s on Wed, 29 Nov, 03:49 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16964

  9. TYPO3com voted on patch set 3 V +1 11/29/17, 14:51 Completed build in 12m 02s on Wed, 29 Nov, 03:51 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16963

  10. Sebastian Hofer commented on patch set 4 CR +1 V +1 11/29/17, 17:11

    As far as we don't have to support email links there everything looks fine :-).
  11. Riccardo De Contardi commented on patch set 4 V +1 11/29/17, 20:18

    tested with links that begins with "www", "http" and "https"; tested with hitting space and carriage return. - does not work for emails (would be cool, with obfuscation, too) - does not work hitting shift+carriage return (<br>)
  12. Susi Moog voted on patch set 4 CR +2 V +2 11/29/17, 22:14

  13. Gerrit merged patch set 4 11/29/17, 22:15

  14. Susi Moog commented on patch set 5 11/29/17, 22:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ce2c0cf61c9b921e7b71d7dc99861f42cd37285c