Review main Merged

54614[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion

Andreas Kienast CR +2 V +2 Normal +117 −0 updated 11/13/17, 19:17

Commit message

With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported
by code completion.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1318

  1. Andreas Kienast uploaded patch set 1 11/10/17, 13:16

  2. Mathias Brodala updated the commit message in patch set 2 11/10/17, 13:18

  3. TYPO3com voted on patch set 1 V +1 11/10/17, 13:27 Completed build in 10m 57s on Fri, 10 Nov, 02:27 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16238

  4. TYPO3com voted on patch set 2 V +1 11/10/17, 13:28 Completed build in 10m 14s on Fri, 10 Nov, 02:28 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16239

  5. Benjamin Kott commented on patch set 2 CR -1 11/10/17, 14:18

    Default properties like stdWrap are missing, also the highlighting does not recognize "FLUIDTEMPLATE" as object
  6. Andreas Kienast uploaded patch set 3 11/10/17, 14:21

  7. Andreas Kienast uploaded patch set 4 11/10/17, 14:22

  8. Benjamin Kott voted on patch set 4 CR +1 V +1 11/10/17, 14:30

  9. TYPO3com voted on patch set 3 V +1 11/10/17, 14:32 Completed build in 10m 51s on Fri, 10 Nov, 03:32 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16242

  10. TYPO3com voted on patch set 4 V +1 11/10/17, 14:33 Completed build in 11m 36s on Fri, 10 Nov, 03:33 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16243

  11. Jörg Bösche commented on patch set 5 11/13/17, 08:47

    Published edit on patch set 4.
  12. TYPO3com voted on patch set 5 V +1 11/13/17, 09:01 Completed build in 13m 50s on Mon, 13 Nov, 10:01 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16275

  13. Stefan Neufeind commented on patch set 5 CR -1 11/13/17, 09:03

    tsref.xml:1066

    extbase? not part of this patch or the commit-msg should include that somehow imho
  14. Andreas Kienast commented on patch set 5 11/13/17, 09:09

    tsref.xml:1066 Reply

    Extbase is a needed subsection of FLUIDTEMPLATE, please see the docs: https://docs.typo3.org/typo3cms/TyposcriptReference/ContentObjects/Fluidtemplate/Index.html
  15. Stefan Neufeind voted on patch set 5 CR +1 11/13/17, 09:36

  16. Stefan Neufeind voted on patch set 5 V +1 11/13/17, 10:04

  17. Georg Ringer voted on patch set 5 CR +2 V +2 11/13/17, 19:17

  18. Gerrit merged patch set 5 11/13/17, 19:17