Review main Merged

54619[TASK] Extend untangleFilesArray function test in RequestBuilder

Joshua Westerheide CR +2 V +2 Easy +26 −0 updated 02/20/18, 03:40

Commit message

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Benni Mack +1
  • Verified V +2
    • Stefan Neufeind +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Joshua Westerheide uploaded patch set 1 11/11/17, 16:46

  2. TYPO3com voted on patch set 1 V +1 11/11/17, 16:55 Completed build in 09m 31s on Sat, 11 Nov, 05:55 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16259

  3. Stefan Neufeind updated the commit message in patch set 2 11/12/17, 00:46

  4. Stefan Neufeind commented on patch set 2 CR +1 11/12/17, 00:48

    Moved from feature to task since it's only existing a test. Adjusted commit-message a bit to reflect what it does. That the test still runs can imho be skipped (as I did here) and of course covering more edge-cases is a good thing.
  5. TYPO3com voted on patch set 2 V +1 11/12/17, 00:55 Completed build in 09m 28s on Sun, 12 Nov, 01:55 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16262

  6. Benni Mack updated the commit message in patch set 3 11/14/17, 07:25

  7. Benni Mack voted on patch set 3 CR +1 V +1 11/14/17, 07:25

  8. TYPO3com voted on patch set 3 V -1 11/14/17, 07:34 Completed build in 09m 06s on Tue, 14 Nov, 08:34 AM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16314

  9. Wouter Wolters rebased onto patch set 4 11/14/17, 19:03

  10. TYPO3com voted on patch set 4 V +1 11/14/17, 19:13 Completed build in 10m 30s on Tue, 14 Nov, 08:13 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16354

  11. Stefan Neufeind voted on patch set 4 CR +1 V +1 11/15/17, 07:21

  12. Benni Mack voted on patch set 4 CR +1 V +1 11/15/17, 07:22

  13. Stefan Neufeind voted on patch set 4 CR +2 V +2 11/15/17, 07:22

  14. Gerrit merged patch set 4 11/15/17, 07:22

  15. Stephan Großberndt commented on patch set 5 12/20/17, 16:46

    Backport to 8.7 and 7.6 is missing
  16. Stephan Großberndt commented on patch set 5 02/19/18, 20:53

    ping
  17. Stefan Neufeind commented on patch set 5 02/20/18, 03:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ea42b0f5f634c8af5f8789beb2c314e66440a280
  18. Stefan Neufeind commented on patch set 5 02/20/18, 03:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit dbd969e621e20500b9749bc4f2046910375ae9b8