Review main Abandoned

54624[BUGFIX] ModuleMenu::loadNavigationComponent must load custom tree

Sebastian Fischer CR 0 V 0 Easy +7 −4 updated 11/30/17, 20:14

Commit message

This patch changes initialization of the pagetree to make it possible
to open a custom module with its own navigation directly without the
need to open a Web/* module after opening the backend.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1215

  1. Sebastian Fischer uploaded patch set 1 11/13/17, 05:42

  2. TYPO3com voted on patch set 1 V +1 11/13/17, 05:51 Completed build in 09m 02s on Mon, 13 Nov, 06:51 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16271

  3. Tymoteusz Motylewski commented on patch set 1 V -1 11/14/17, 13:30

    I see 2 issues in the browser (chrome) console log. ModuleMenu.js?bust=f452c88c1d9191e94460224c49e4448f1a10b839:227 jQuery.Deferred exception: this.availableNavigationComponents.typo3-pagetree.isInitialized is not a function TypeError: this.availableNavigationComponents.typo3-pagetree.isInitialized is not a function after entering any module (page/list) and jquery-3.2.1.min-fcd4878e553a6d1ce848bd4f9284769e.js:2 jQuery.Deferred exception: selectNode is not defined ReferenceError: selectNode is not defined after clicking on the page tree node
  4. Sebastian Fischer uploaded patch set 2 11/19/17, 17:24

  5. TYPO3com voted on patch set 2 V +1 11/19/17, 17:34 Completed build in 09m 18s on Sun, 19 Nov, 06:34 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16474

  6. Sebastian Fischer uploaded patch set 3 11/20/17, 06:34

  7. TYPO3com voted on patch set 3 V +1 11/20/17, 06:44 Completed build in 09m 14s on Mon, 20 Nov, 07:44 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16480

  8. Wouter Wolters voted on patch set 3 CR +1 11/20/17, 09:27

  9. Markus Klein voted on patch set 3 CR +1 11/20/17, 09:27

  10. Benni Mack voted on patch set 3 CR +1 11/24/17, 21:15

  11. Markus Klein commented on patch set 3 11/28/17, 10:26

    @Sebastian: Please add testing instructions to the forge ticket. Thx
  12. Andreas Kienast voted on patch set 3 CR +1 11/30/17, 08:39

  13. Benni Mack commented on patch set 3 11/30/17, 14:30

    So this should only go in v8 now, needs to be repushed into TYPO3_8-7 branch
  14. Wouter Wolters commented on patch set 3 11/30/17, 20:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2dc92ade47b63a1282e8728de725a426f1eb3d26
  15. Wouter Wolters abandoned the change 11/30/17, 20:14

    abandoned for master, created the 8.7 version.