Review main Merged

54631[BUGFIX] Stabilize Language Acceptance tests

Mathias Schreiber CR +2 V +2 Easy +7 −10 updated 11/14/17, 18:33

Commit message

Stabilize the acceptance tests to activate and deactivate a language by
checking only for the alerts instead of the enabled/disabled rows.

Additionally make the download a language test fail immediately if the
language is enabled.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2031

Show 36 earlier messages
  1. Mathias Schreiber uploaded patch set 1 11/13/17, 18:02

  2. TYPO3com voted on patch set 1 V +1 11/13/17, 18:14 Completed build in 11m 07s on Mon, 13 Nov, 07:14 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16291

  3. TYPO3com commented on patch set 1 11/13/17, 19:32 Completed build in 33m 17s on Mon, 13 Nov, 08:32 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16291

  4. Stephan Großberndt updated the commit message in patch set 2 11/13/17, 22:01

  5. TYPO3com voted on patch set 2 V +1 11/13/17, 22:10 Completed build in 08m 58s on Mon, 13 Nov, 11:10 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16304

  6. Stefan Neufeind commented on patch set 2 CR +1 V +1 11/14/17, 06:51

    Sounds like a good plan. Nothing really to "verify" here.
  1. Stephan Großberndt commented on patch set 2 CR -1 11/14/17, 07:36

    The current patch is not going to change anything. I did some research and added that to the ticket, please have a look. It is not the alert but the line before where it fails.
  2. Stefan Neufeind voted on patch set 2 CR 0 V 0 11/14/17, 07:50

  3. Susi Moog commented on patch set 3 11/14/17, 09:11

    Published edit on patch set 2.
  4. Stephan Großberndt voted on patch set 3 CR +1 11/14/17, 09:13

  5. TYPO3com voted on patch set 3 V -1 11/14/17, 09:20 Completed build in 09m 22s on Tue, 14 Nov, 10:20 AM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16318

  6. Susi Moog commented on patch set 4 11/14/17, 09:28

    Published edit on patch set 3.
  7. TYPO3com voted on patch set 4 V -1 11/14/17, 09:39 Completed build in 11m 03s on Tue, 14 Nov, 10:39 AM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16320

  8. Christian Kuhn commented on patch set 5 11/14/17, 11:59

    Published edit on patch set 4.
  9. TYPO3com voted on patch set 5 V +1 11/14/17, 12:09 Completed build in 09m 38s on Tue, 14 Nov, 01:09 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16323

  10. Stephan Großberndt commented on patch set 5 11/14/17, 12:12

    Why are there separate checks for language and language.disabled?
  11. Christian Kuhn commented on patch set 6 11/14/17, 12:35

    Published edit on patch set 5.
  12. TYPO3com voted on patch set 6 V +1 11/14/17, 12:45 Completed build in 08m 59s on Tue, 14 Nov, 01:45 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16327

  13. Stephan Großberndt commented on patch set 7 11/14/17, 12:46

    Published edit on patch set 6.
  14. Stephan Großberndt commented on patch set 8 11/14/17, 12:48

    Published edit on patch set 7.
  15. Stephan Großberndt updated the commit message in patch set 9 11/14/17, 12:52

  16. TYPO3com voted on patch set 8 V +1 11/14/17, 12:58 Completed build in 10m 00s on Tue, 14 Nov, 01:58 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16329

  17. TYPO3com voted on patch set 7 V +1 11/14/17, 12:59 Completed build in 12m 56s on Tue, 14 Nov, 01:59 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16328

  18. TYPO3com voted on patch set 9 V +1 11/14/17, 13:02 Completed build in 09m 59s on Tue, 14 Nov, 02:02 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16330

  19. Stephan Großberndt voted on patch set 9 CR +1 11/14/17, 13:16

  20. Susi Moog voted on patch set 9 CR +1 V +1 11/14/17, 16:56

  21. TYPO3com commented on patch set 9 11/14/17, 17:06 Completed build in 19m 05s on Tue, 14 Nov, 06:06 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16330

  22. Wouter Wolters voted on patch set 9 CR +1 11/14/17, 17:53

  23. Christian Kuhn commented on patch set 9 CR +1 V +1 11/14/17, 17:57

    will merge as soon as v8 version of the patch goes green.
  24. Christian Kuhn voted on patch set 9 CR +2 V +2 11/14/17, 18:33

  25. Gerrit merged patch set 9 11/14/17, 18:33