54634[!!!][TASK] Remove BE/fileExtensions/webspace
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −28
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php3+5 −11
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −8
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-83081-RemovedConfigurationOptionBeFileExtensionsWebspace.rst1new+36 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+0 −51
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php1+2 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php1+10 −0
Review log 2536
Show 711 earlier messages
-
Benni Mack uploaded patch set 1 11/14/17, 06:48
-
TYPO3com voted on patch set 1 V -1 11/14/17, 06:48 Completed build in 09s on Tue, 14 Nov, 07:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16310
-
Benni Mack uploaded patch set 2 11/14/17, 06:48
-
TYPO3com voted on patch set 2 V +1 11/14/17, 06:57 Completed build in 08m 55s on Tue, 14 Nov, 07:57 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16311
-
Benni Mack updated the commit message in patch set 3 11/24/17, 20:55
-
TYPO3com voted on patch set 3 V +1 11/24/17, 21:04 Completed build in 09m 35s on Fri, 24 Nov, 10:04 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16593
-
Benni Mack uploaded patch set 4 11/27/17, 16:04
-
TYPO3com voted on patch set 4 V +1 11/27/17, 16:19 Completed build in 15m 09s on Mon, 27 Nov, 05:19 PM Test Summary: 56816 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16688
-
Sebastian Hofer voted on patch set 4 CR +1 11/27/17, 20:48
-
Jörg Bösche voted on patch set 4 CR +1 11/28/17, 06:20
-
Henning Liebe voted on patch set 4 CR +1 11/28/17, 08:19
-
Susi Moog commented on patch set 4 CR -1 11/28/17, 11:42
-
Susi Moog uploaded patch set 5 11/28/17, 12:34
-
Susi Moog updated the commit message in patch set 6 11/28/17, 12:35
-
TYPO3com voted on patch set 5 V +1 11/28/17, 12:51 Completed build in 17m 17s on Tue, 28 Nov, 01:51 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16810
-
TYPO3com voted on patch set 6 V +1 11/28/17, 12:54 Completed build in 18m 30s on Tue, 28 Nov, 01:54 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16811
-
Tomas Norre Mikkelsen commented on patch set 6 11/28/17, 14:29
BasicFileUtility.php:72Will this not conflict as allow and deny has the same value ? -
Susi Moog commented on patch set 7 11/28/17, 14:35
Published edit on patch set 6. -
Susi Moog commented on patch set 7 11/28/17, 14:35
BasicFileUtility.php:72Replygood point. -
Tomas Norre Mikkelsen voted on patch set 7 CR +1 11/28/17, 14:44
-
TYPO3com voted on patch set 7 V +1 11/28/17, 14:49 Completed build in 13m 59s on Tue, 28 Nov, 03:49 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16825
-
Christian Kuhn commented on patch set 7 CR -1 11/28/17, 14:51
should have an update since the setting is now removed entirely. -
Susi Moog uploaded patch set 8 11/28/17, 16:57
-
TYPO3com voted on patch set 8 V -1 11/28/17, 17:07 Completed build in 10m 29s on Tue, 28 Nov, 06:07 PM Test Summary: 8 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16844
-
TYPO3com commented on patch set 8 11/28/17, 19:23 Completed build in 2h 36m 33s on Tue, 28 Nov, 08:23 PM Test Summary: 8 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16844
-
Christian Kuhn commented on patch set 8 CR -1 11/28/17, 19:27
SilentConfigurationUpgradeService.php:152no such method ;) -
Christian Kuhn commented on patch set 8 11/28/17, 19:27
will push update -
Christian Kuhn uploaded patch set 9 11/28/17, 19:28
-
TYPO3com voted on patch set 9 V +1 11/28/17, 19:37 Completed build in 09m 02s on Tue, 28 Nov, 08:37 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16857
-
Benni Mack commented on patch set 9 CR -1 11/28/17, 19:39
BasicFileUtility.php:70can't we get rid of the constructor? Also, the comment above can be removed.Breaking-83081-RemovedConfigurationOptionBeFileExtensionsWebspace.rst:35should be automatically removed, right? -
Susi Moog uploaded patch set 10 11/28/17, 21:10
-
TYPO3com voted on patch set 10 V +1 11/28/17, 21:19 Completed build in 09m 28s on Tue, 28 Nov, 10:19 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16869
-
Benni Mack voted on patch set 10 CR +1 V +1 11/28/17, 22:05
-
Christian Kuhn voted on patch set 10 CR +1 V +1 11/28/17, 22:40
-
Susi Moog voted on patch set 10 CR +2 V +2 11/28/17, 22:41
-
Gerrit merged patch set 10 11/28/17, 22:41
ArrayDimensionMatcher.php:127