Review main Merged

54640[BUGFIX] Use correct parameters for trimExplode

Wouter Wolters CR +2 V +2 Easy +10 −1 updated 11/16/17, 12:37

Commit message

In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of
trimExplode is inserted. To prevent notices array_pad is added.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Jigal van Hemert +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Wouter Wolters uploaded patch set 1 11/14/17, 18:06

  2. TYPO3com voted on patch set 1 V +1 11/14/17, 18:17 Completed build in 10m 20s on Tue, 14 Nov, 07:17 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16348

  3. Frans Saris voted on patch set 1 CR +1 11/14/17, 18:30

  4. Alexander Schnitzler voted on patch set 1 CR +1 11/15/17, 12:53

  5. Morton Jonuschat voted on patch set 1 CR +1 V +1 11/15/17, 13:46

  6. Tymoteusz Motylewski commented on patch set 1 11/15/17, 13:51

    QueryBuilder.php:972

    in order to avoid notices this should be: list($fieldName, $alias, $suffix) = array_pad(GeneralUtility::trimExplode(' AS ', str_ireplace(' as ', ' AS ', $select), true, 3), 3, null);
  7. Jigal van Hemert uploaded patch set 2 11/15/17, 22:21

  8. Jigal van Hemert voted on patch set 2 CR +1 V +1 11/15/17, 22:22

  9. TYPO3com voted on patch set 2 V +1 11/15/17, 22:30 Completed build in 08m 26s on Wed, 15 Nov, 11:30 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16402

  10. Tymoteusz Motylewski voted on patch set 2 CR +2 V +2 11/16/17, 10:35

  11. Gerrit merged patch set 2 11/16/17, 10:35

  12. Tymoteusz Motylewski commented on patch set 3 11/16/17, 12:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0d058021ffa4aa255e879c137789b6d57585b2a8